diff --git a/engine/schema/src/com/cloud/upgrade/dao/Upgrade430to440.java b/engine/schema/src/com/cloud/upgrade/dao/Upgrade430to440.java index 8478f83ac29..8e6147aa141 100644 --- a/engine/schema/src/com/cloud/upgrade/dao/Upgrade430to440.java +++ b/engine/schema/src/com/cloud/upgrade/dao/Upgrade430to440.java @@ -242,6 +242,9 @@ public class Upgrade430to440 implements DbUpgrade { pstmtItem = conn.prepareStatement(networkAclItemSql); rsItems = pstmtItem.executeQuery(); + String networkAclItemCidrSql = "INSERT INTO `cloud`.`network_acl_item_cidrs` (network_acl_item_id, cidr) VALUES (?,?)"; + pstmtCidr = conn.prepareStatement(networkAclItemCidrSql); + // for each network acl item while(rsItems.next()) { long itemId = rsItems.getLong(1); @@ -251,8 +254,6 @@ public class Upgrade430to440 implements DbUpgrade { // split it String[] cidrArray = cidrList.split(","); // insert a record per cidr - String networkAclItemCidrSql = "INSERT INTO `cloud`.`network_acl_item_cidrs` (network_acl_item_id, cidr) VALUES (?,?)"; - pstmtCidr = conn.prepareStatement(networkAclItemCidrSql); pstmtCidr.setLong(1, itemId); for (String cidr : cidrArray) { pstmtCidr.setString(2, cidr);