From 01538e4d1e76d4e1a4740422bde0ae9872922dba Mon Sep 17 00:00:00 2001 From: alena Date: Mon, 13 Jun 2011 15:08:36 -0700 Subject: [PATCH] bug 9511: use new StringBuffer for each PF/StaticNat rule status 9511: resolved fixed --- .../xen/resource/CitrixResourceBase.java | 18 ++++++++++-------- 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/core/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java b/core/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java index 214596a6c66..55c52a1198f 100644 --- a/core/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java +++ b/core/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java @@ -1239,19 +1239,21 @@ public abstract class CitrixResourceBase implements ServerResource, HypervisorRe Connection conn = getConnection(); String routerIp = cmd.getAccessDetail(NetworkElementCommand.ROUTER_IP); - String args = routerIp; + //String args = routerIp; String[] results = new String[cmd.getRules().length]; int i = 0; for (StaticNatRuleTO rule : cmd.getRules()) { //1:1 NAT needs instanceip;publicip;domrip;op - args += rule.revoked() ? " -D " : " -A "; - args += " -l " + rule.getSrcIp(); - args += " -r " + rule.getDstIp(); - args += " -P " + rule.getProtocol().toLowerCase(); - args += " -d " + rule.getStringSrcPortRange(); - args += " -G " ; + StringBuilder args = new StringBuilder(); + args.append(routerIp); + args.append(rule.revoked() ? " -D " : " -A "); + args.append(" -l ").append(rule.getSrcIp()); + args.append(" -r ").append(rule.getDstIp()); + args.append(" -P ").append(rule.getProtocol().toLowerCase()); + args.append(" -d ").append(rule.getStringSrcPortRange()); + args.append(" -G "); - String result = callHostPlugin(conn, "vmops", "setFirewallRule", "args", args); + String result = callHostPlugin(conn, "vmops", "setFirewallRule", "args", args.toString()); results[i++] = (result == null || result.isEmpty()) ? "Failed" : null; }