bug 6048: Check createvolume's return

status 6048: resolved fixed
This commit is contained in:
anthony 2010-08-31 12:57:24 -07:00
parent 3b939b9ce1
commit 01b2a32ed9
1 changed files with 6 additions and 2 deletions

View File

@ -798,8 +798,9 @@ public class StorageManagerImpl implements StorageManager {
return vols;
} catch (Exception e) {
s_logger.error("Unexpected exception ", e);
if (s_logger.isDebugEnabled()) {
s_logger.debug(e.getMessage());
}
if (rootCreated != null) {
destroyVolume(rootCreated);
}
@ -812,6 +813,9 @@ public class StorageManagerImpl implements StorageManager {
public long createUserVM(Account account, VMInstanceVO vm, VMTemplateVO template, DataCenterVO dc, HostPodVO pod, ServiceOfferingVO offering, DiskOfferingVO diskOffering,
List<StoragePoolVO> avoids) {
List<VolumeVO> volumes = create(account, vm, template, dc, pod, offering, diskOffering, avoids);
if( volumes == null || volumes.size() == 0) {
throw new CloudRuntimeException("Unable to create volume for " + vm.getName());
}
for (VolumeVO v : volumes) {
long volumeId = v.getId();