etan39
/
cloudstack
mirror of https://github.com/apache/cloudstack.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Address copilot's review

This commit is contained in:
Erik Böck 2026-03-20 08:00:52 -03:00
parent bedd77fe8b
commit 02a1d071fc
4 changed files with 4 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
api/src/main/java/org/apache/cloudstack/api/command/user/vm/AddIpToVmNicCmd.java
View File

@ -56,7 +56,7 @@ public class AddIpToVmNicCmd extends BaseAsyncCreateCmd {
@Parameter(name = ApiConstants.IP_ADDRESS, type = CommandType.STRING, required = false, description = "Secondary IP Address")
private String ipAddr;
@Parameter(name = ApiConstants.DESCRIPTION, type = CommandType.STRING, required = false, description = "Description")
@Parameter(name = ApiConstants.DESCRIPTION, type = CommandType.STRING, required = false, description = "Description", length = 2048)
private String description;
/////////////////////////////////////////////////////

2
server/src/main/java/com/cloud/network/rules/RulesManagerImpl.java
View File

@ -467,7 +467,7 @@ public class RulesManagerImpl extends ManagerBase implements RulesManager, Rules
boolean isOneToOneNat = ipAddress.isOneToOneNat();
Long associatedWithVmId = ipAddress.getAssociatedWithVmId();
Nic guestNic;
wNicSecondaryIpVO nicSecIp = null;
NicSecondaryIpVO nicSecIp = null;
String dstIp = null;
Network network = _networkModel.getNetwork(networkId);

3
ui/src/views/network/NicsTab.vue
View File

@ -218,8 +218,7 @@
<p class="modal-form__label">{{ $t('label.secondaryip.description') }}</p>
<a-input
:placeholder="$t('label.new.secondaryip.description.description')"
v-model:value="newSecondaryIpDescription"
v-focus="editNicResource.type!=='Shared'"></a-input>
v-model:value="newSecondaryIpDescription"></a-input>
</div>
<div style="margin-top: 10px; display: flex; justify-content:flex-end;">

2
ui/src/views/network/NicsTable.vue
View File

@ -39,7 +39,7 @@
{{ record.traffictype }}
</a-descriptions-item>
<a-descriptions-item :label="$t('label.secondaryips')" v-if="record.secondaryip && record.secondaryip.length > 0 && record.type !== 'L2'">
{{ record.secondaryip.map(x => x.ipaddress + ': ' + x.description ).join(', ') }}
{{ record.secondaryip.map(x => x.description ? (x.ipaddress + ': ' + x.description) : x.ipaddress).join(', ') }}
</a-descriptions-item>
<a-descriptions-item :label="$t('label.ip6address')" v-if="record.ip6address">
{{ record.ip6address }}