From 04731b06182d1b14c80b372939362e8878366ec7 Mon Sep 17 00:00:00 2001
From: Pearl Dsilva <pearl1594@gmail.com>
Date: Mon, 12 May 2025 12:58:41 +0530
Subject: [PATCH] fix logger

---
 .../wrapper/LibvirtGetVmIpAddressCommandWrapper.java   |  2 +-
 .../wrapper/xenbase/CitrixCleanupVMCommandWrapper.java | 10 +++-------
 .../hypervisor/vmware/mo/HypervisorHostHelper.java     |  2 +-
 3 files changed, 5 insertions(+), 9 deletions(-)

diff --git a/plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtGetVmIpAddressCommandWrapper.java b/plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtGetVmIpAddressCommandWrapper.java
index 9aef5bb581f..93545f3adcf 100644
--- a/plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtGetVmIpAddressCommandWrapper.java
+++ b/plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtGetVmIpAddressCommandWrapper.java
@@ -136,7 +136,7 @@ public final class LibvirtGetVmIpAddressCommandWrapper extends CommandWrapper<Ge
                 ipv6 = ipPart;
             }
         }
-        s_logger.debug(String.format("Found ipv4: %s and ipv6: %s with mac address %s", ipv4, ipv6, macAddress));
+        logger.debug(String.format("Found ipv4: %s and ipv6: %s with mac address %s", ipv4, ipv6, macAddress));
         return new Pair<>(ipv4, ipv6);
     }
 
diff --git a/plugins/hypervisors/xenserver/src/main/java/com/cloud/hypervisor/xenserver/resource/wrapper/xenbase/CitrixCleanupVMCommandWrapper.java b/plugins/hypervisors/xenserver/src/main/java/com/cloud/hypervisor/xenserver/resource/wrapper/xenbase/CitrixCleanupVMCommandWrapper.java
index 3b0408379ef..fc29883ad8c 100644
--- a/plugins/hypervisors/xenserver/src/main/java/com/cloud/hypervisor/xenserver/resource/wrapper/xenbase/CitrixCleanupVMCommandWrapper.java
+++ b/plugins/hypervisors/xenserver/src/main/java/com/cloud/hypervisor/xenserver/resource/wrapper/xenbase/CitrixCleanupVMCommandWrapper.java
@@ -20,8 +20,6 @@ package com.cloud.hypervisor.xenserver.resource.wrapper.xenbase;
 import java.util.Iterator;
 import java.util.Set;
 
-import org.apache.log4j.Logger;
-
 import com.cloud.agent.api.Answer;
 import com.cloud.agent.api.CleanupVMCommand;
 import com.cloud.hypervisor.xenserver.resource.CitrixResourceBase;
@@ -34,12 +32,10 @@ import com.xensource.xenapi.VM;
 @ResourceWrapper(handles =  CleanupVMCommand.class)
 public class CitrixCleanupVMCommandWrapper extends CommandWrapper<CleanupVMCommand, Answer, CitrixResourceBase> {
 
-    private static final Logger s_logger = Logger.getLogger(CitrixCleanupVMCommandWrapper.class);
-
     @Override
     public Answer execute(final CleanupVMCommand command, final CitrixResourceBase citrixResourceBase) {
         if (citrixResourceBase.isDestroyHaltedVms()) {
-            s_logger.debug(String.format("Cleanup VM is not needed for host with version %s",
+            logger.debug(String.format("Cleanup VM is not needed for host with version %s",
                     citrixResourceBase.getHost().getProductVersion()));
             return new Answer(command);
         }
@@ -57,7 +53,7 @@ public class CitrixCleanupVMCommandWrapper extends CommandWrapper<CleanupVMComma
                 final VM.Record vmr = vm.getRecord(conn);
                 if (!Types.VmPowerState.HALTED.equals(vmr.powerState)) {
                     final String msg = String.format("VM %s is not in %s state", vmName, Types.VmPowerState.HALTED);
-                    s_logger.error(msg);
+                    logger.error(msg);
                     return new Answer(command, false, msg);
                 }
                 if (citrixResourceBase.isRefNull(vmr.residentOn)) {
@@ -74,7 +70,7 @@ public class CitrixCleanupVMCommandWrapper extends CommandWrapper<CleanupVMComma
 
         } catch (final Exception e) {
             final String msg = String.format("Clean up VM %s fail due to %s", vmName, e);
-            s_logger.error(msg, e);
+            logger.error(msg, e);
             return new Answer(command, false, e.getMessage());
         }
         return new Answer(command);
diff --git a/vmware-base/src/main/java/com/cloud/hypervisor/vmware/mo/HypervisorHostHelper.java b/vmware-base/src/main/java/com/cloud/hypervisor/vmware/mo/HypervisorHostHelper.java
index ba4b0ebe801..1dc6ab64f0a 100644
--- a/vmware-base/src/main/java/com/cloud/hypervisor/vmware/mo/HypervisorHostHelper.java
+++ b/vmware-base/src/main/java/com/cloud/hypervisor/vmware/mo/HypervisorHostHelper.java
@@ -300,7 +300,7 @@ public class HypervisorHostHelper {
         String networkName = sb.toString();
         if (networkName.length() > 80) {
             // the maximum limit for a vSwitch name is 80 chars, applies to both standard and distributed virtual switches.
-            s_logger.warn(String.format("The network name: %s for the vSwitch %s of type %s, exceeds 80 chars", networkName, vSwitchName, vSwitchType));
+            LOGGER.warn(String.format("The network name: %s for the vSwitch %s of type %s, exceeds 80 chars", networkName, vSwitchName, vSwitchType));
         }
         return networkName;
     }