bug 13625: F5 - NullPointerException seen when trying to delete/restart a network that was failed to implement properly during implement network

Reviewed-By: Abhi
status 13625: resolved fixed

adding logic to gracefully exit shutdown operation, if earlier network failed to implement
This commit is contained in:
Murali reddy 2012-02-16 18:47:37 +05:30
parent 2e92688b00
commit 060da55233
1 changed files with 6 additions and 1 deletions

View File

@ -926,7 +926,7 @@ public abstract class ExternalLoadBalancerDeviceManagerImpl extends AdapterBase
// find the load balancer device allocated for the network
ExternalLoadBalancerDeviceVO lbDeviceVO = getExternalLoadBalancerForNetwork(guestConfig);
if (lbDeviceVO == null) {
s_logger.warn("network shutdwon requested on external load balancer, which did not implement the network." +
s_logger.warn("Network shutdwon requested on external load balancer element, which did not implement the network." +
" Either network implement failed half way through or already network shutdown is completed. So just returning.");
return true;
}
@ -952,6 +952,11 @@ public abstract class ExternalLoadBalancerDeviceManagerImpl extends AdapterBase
} else {
// get the self-ip used by the load balancer
NicVO selfipNic = getPlaceholderNic(guestConfig);
if (selfipNic == null) {
s_logger.warn("Network shutdwon requested on external load balancer element, which did not implement the network." +
" Either network implement failed half way through or already network shutdown is completed. So just returning.");
return true;
}
selfIp = selfipNic.getIp4Address();
}