etan39
/
cloudstack
mirror of https://github.com/apache/cloudstack.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

CLOUDSTACK-8766: Fix infinite scrolling pagination for zonal iso/template listing 

Due to aggregation of templates and isos on the UI/client side, it could result
that for each page we could end up having lesser templates/isos listed to have
the scroll shown that triggers infinite scrolling. In theory, there
is still a chance if there are several zones with the same template being listed
resulting in only one aggregated template which could cause the scroll to not
get shown; but in practice I believe this fix should work for most users.

Page size set based on experimental data:
https://github.com/apache/cloudstack/pull/751#issuecomment-135661968

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
This commit is contained in:
Rohit Yadav 2015-08-27 12:31:04 +05:30
parent 5522120b0e
commit 069e3f92ad
1 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
ui/scripts/templates.js
View File

@ -586,6 +586,9 @@
dataProvider: function(args) {
var data = {};
listViewDataProvider(args, data);
// Due to zonal grouping, low pagesize can result lower
// aggregated items, resulting in no scroll shown
data.pagesize = 200;
var ignoreProject = false;
if (args.filterBy != null) { //filter dropdown
@ -1727,6 +1730,9 @@
dataProvider: function(args) {
var data = {};
listViewDataProvider(args, data);
// Due to zonal grouping, low pagesize can result lower
// aggregated items, resulting in no scroll shown
data.pagesize = 200;
var ignoreProject = false;
if (args.filterBy != null) { //filter dropdown