From 0ca3b4a4e4786676e13ec67c2cbc17b530917765 Mon Sep 17 00:00:00 2001 From: Santhosh Edukulla Date: Tue, 5 Aug 2014 17:28:37 +0530 Subject: [PATCH] Fixed coverity reported concurrency issue Signed-off-by: Santhosh Edukulla --- .../apache/cloudstack/framework/rpc/RpcClientCallImpl.java | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/framework/ipc/src/org/apache/cloudstack/framework/rpc/RpcClientCallImpl.java b/framework/ipc/src/org/apache/cloudstack/framework/rpc/RpcClientCallImpl.java index 7ccd8bbaa78..a3dea79926d 100644 --- a/framework/ipc/src/org/apache/cloudstack/framework/rpc/RpcClientCallImpl.java +++ b/framework/ipc/src/org/apache/cloudstack/framework/rpc/RpcClientCallImpl.java @@ -193,9 +193,8 @@ public class RpcClientCallImpl implements RpcClientCall { @SuppressWarnings("unchecked") public void complete(String result) { - _responseResult = result; - synchronized (_responseLock) { + _responseResult = result; _responseDone = true; _responseLock.notifyAll(); } @@ -213,11 +212,10 @@ public class RpcClientCallImpl implements RpcClientCall { } public void complete(RpcException e) { - _responseResult = e; synchronized (_responseLock) { + _responseResult = e; _responseDone = true; - _responseLock.notifyAll(); }