From 0ebca4cdf8311bf3809507a25714914818a57b6c Mon Sep 17 00:00:00 2001 From: prachi Date: Fri, 18 Nov 2011 13:05:52 -0800 Subject: [PATCH] AddNetworkServiceProvider should check if the services specified are provided by the provider to be added. --- server/src/com/cloud/network/NetworkManagerImpl.java | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/server/src/com/cloud/network/NetworkManagerImpl.java b/server/src/com/cloud/network/NetworkManagerImpl.java index 92ef2f5408f..420b7d75256 100755 --- a/server/src/com/cloud/network/NetworkManagerImpl.java +++ b/server/src/com/cloud/network/NetworkManagerImpl.java @@ -4168,6 +4168,11 @@ public class NetworkManagerImpl implements NetworkManager, NetworkService, Manag } else if (service == Service.SourceNat) { addGatewayService = true; } + + //check if the service is provided by this Provider + if(!element.getCapabilities().containsKey(service)){ + throw new InvalidParameterValueException(providerName+" Provider cannot provide this Service specified=" + serviceName); + } services.add(service); }