etan39
/
cloudstack
mirror of https://github.com/apache/cloudstack.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

CLOUDSTACK-933: CglibThrowableRendererTest writing stack traces... 

Improve CglibThrowableRenderer test case

Log to a separate Logger instead of the default one to avoid spurious
stack traces in test run output.

Actually verify that registering CglibThrowableRenderer with the
alternative log hierarchy actually removes call trace lines that
contains the string <generated>
This commit is contained in:
Noa Resare 2013-01-09 16:39:10 +01:00 committed by Chip Childers
parent d8ebd5e4f9
commit 1033200b0b
1 changed files with 36 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

38
utils/test/com/cloud/utils/log/CglibThrowableRendererTest.java
View File

@ -18,14 +18,21 @@ package com.cloud.utils.log;
import junit.framework.TestCase;
import org.apache.log4j.Logger;
import org.apache.log4j.*;
import com.cloud.utils.component.ComponentLocator;
import com.cloud.utils.db.DB;
import com.cloud.utils.exception.CloudRuntimeException;
import org.apache.log4j.spi.RootLogger;
import org.apache.log4j.spi.ThrowableRenderer;
import java.io.CharArrayWriter;
import java.io.Writer;
public class CglibThrowableRendererTest extends TestCase {
static Logger another = Logger.getLogger("TEST");
private final static Logger s_logger = Logger.getLogger(CglibThrowableRendererTest.class);
public static class Test {
@DB
@ -48,13 +55,40 @@ public class CglibThrowableRendererTest extends TestCase {
}
}
}
private Logger getAlternateLogger(Writer writer, ThrowableRenderer renderer) {
Hierarchy hierarchy = new Hierarchy(new RootLogger(Level.INFO));
if (renderer != null) {
hierarchy.setThrowableRenderer(renderer);
}
Logger alternateRoot = hierarchy.getRootLogger();
alternateRoot.addAppender(new WriterAppender(new SimpleLayout(), writer));
return alternateRoot;
}
public void testException() {
Writer w = new CharArrayWriter();
Logger alt = getAlternateLogger(w, null);
Test test = ComponentLocator.inject(Test.class);
try {
test.exception();
} catch (Exception e) {
s_logger.warn("exception caught", e);
alt.warn("exception caught", e);
}
// first check that we actually have some call traces containing "<generated>"
assertTrue(w.toString().contains("<generated>"));
w = new CharArrayWriter();
alt = getAlternateLogger(w, new CglibThrowableRenderer());
try {
test.exception();
} catch (Exception e) {
alt.warn("exception caught", e);
}
// then we check that CglibThrowableRenderer indeed remove those occurrences
assertFalse(w.toString().contains("<generated>"));
}
}