From 1177589a6bb433577c557771ea905aab236bb21b Mon Sep 17 00:00:00 2001
From: Jessica Wang <jessicawang@apache.org>
Date: Fri, 10 May 2013 11:54:17 -0700
Subject: [PATCH] CLOUDSTACK-1816: Cisco VNMC ASA1000v - UI - Infrastructure
 menu - physical network - network service providers - Cisco VNMC - fix a bug
 that detailView loads forever.

---
 ui/modules/infrastructure/infrastructure.js       |  4 ++--
 .../vnmcNetworkProvider/vnmcNetworkProvider.js    | 15 +++++++++++++--
 2 files changed, 15 insertions(+), 4 deletions(-)

diff --git a/ui/modules/infrastructure/infrastructure.js b/ui/modules/infrastructure/infrastructure.js
index 4111aa5af37..55767d3137e 100644
--- a/ui/modules/infrastructure/infrastructure.js
+++ b/ui/modules/infrastructure/infrastructure.js
@@ -36,7 +36,7 @@
           var selectedZoneObj = data.selectedZoneObj;   
           var selectedPhysicalNetworkObj = data.selectedPhysicalNetworkObj;
           if(selectedZoneObj.networktype == "Advanced"){      
-            var selectedProviderObj = {};
+            var selectedProviderObj = null;
             $.ajax({
               url: createURL('listNetworkServiceProviders'),
               data: {
@@ -55,7 +55,7 @@
             nspHardcodingArray.push({
               id: id,
               name: name,
-              state: selectedProviderObj.state
+              state: selectedProviderObj? selectedProviderObj.state : 'Disabled'
             });
           } 
         });
diff --git a/ui/modules/vnmcNetworkProvider/vnmcNetworkProvider.js b/ui/modules/vnmcNetworkProvider/vnmcNetworkProvider.js
index cecf56c79ea..cad4a49a6a5 100644
--- a/ui/modules/vnmcNetworkProvider/vnmcNetworkProvider.js
+++ b/ui/modules/vnmcNetworkProvider/vnmcNetworkProvider.js
@@ -278,8 +278,11 @@
               id: { label: 'label.id' },
               servicelist: {
                 label: 'Services',
-                converter: function(args){                  
-                  return args.join(', ');
+                converter: function(args){  
+                  if(args)                  
+                    return args.join(', ');
+                  else
+                    return '';
                 }
               }
             }
@@ -296,6 +299,14 @@
                 if(items != null && items.length > 0) {   
                   args.response.success({ data: items[0] });                  
                 }
+                else {
+                  args.response.success({ 
+                    data: {
+                      name: 'CiscoVnmc',
+                      state: 'Disabled'
+                    }
+                  })
+                }
               }
             });                 
           }