From 1770f3cb86f84128c40571330af55a7255fa49cc Mon Sep 17 00:00:00 2001
From: Rohit Yadav <rohit.yadav@shapeblue.com>
Date: Wed, 18 May 2016 13:46:18 +0530
Subject: [PATCH] dynamic-roles: remove unnecessary order by ID

On some MySQL server envs, this may cause a SQL statement error, though
I was unable to reproduce it. Since it's not needed, an order by 'sort_order'
is enough, we can safely remove it.

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
---
 .../org/apache/cloudstack/acl/dao/RolePermissionsDaoImpl.java    | 1 -
 1 file changed, 1 deletion(-)

diff --git a/engine/schema/src/org/apache/cloudstack/acl/dao/RolePermissionsDaoImpl.java b/engine/schema/src/org/apache/cloudstack/acl/dao/RolePermissionsDaoImpl.java
index 960b652a3b4..8f6fa83f012 100644
--- a/engine/schema/src/org/apache/cloudstack/acl/dao/RolePermissionsDaoImpl.java
+++ b/engine/schema/src/org/apache/cloudstack/acl/dao/RolePermissionsDaoImpl.java
@@ -156,7 +156,6 @@ public class RolePermissionsDaoImpl extends GenericDaoBase<RolePermissionVO, Lon
             sc.setParameters("roleId", roleId);
         }
         final Filter searchBySorted = new Filter(RolePermissionVO.class, "sortOrder", true, null, null);
-        searchBySorted.addOrderBy(RolePermissionVO.class, "id", true);
         final List<RolePermissionVO> rolePermissionList = listBy(sc, searchBySorted);
         if (rolePermissionList == null) {
             return Collections.emptyList();