add todos

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
This commit is contained in:
Rohit Yadav 2024-08-01 18:15:11 +05:30
parent 11cbea2b15
commit 18e05894c7
2 changed files with 4 additions and 1 deletions

View File

@ -141,6 +141,8 @@ public class NASBackupProvider extends AdapterBase implements BackupProvider, Co
@Override
public boolean takeBackup(final VirtualMachine vm) {
// TODO: currently works for only running VMs
// TODO: add support for backup of stopped VMs
final Host host = getRunningVMHypervisorHost(vm);
final String backupStoragePath = getBackupStoragePath(vm.getDataCenterId());
@ -187,7 +189,7 @@ public class NASBackupProvider extends AdapterBase implements BackupProvider, Co
LOG.debug("Restoring vm " + vm.getUuid() + "from backup " + backup.getUuid() + " on the NAS Backup Provider");
// Find where the VM was last running
final Host hostVO = getLastVMHypervisorHost(vm);
final Host host = getLastVMHypervisorHost(vm);
// TODO: get KVM agent to restore VM backup

View File

@ -42,6 +42,7 @@ backup_vm() {
virsh -c qemu:///system backup-begin --domain $vm --backupxml $dest/backup.xml > /dev/null 2>/dev/null
virsh -c qemu:///system dumpxml $vm > $dest/domain-$vm.xml 2>/dev/null
rm -f $dest/backup.xml
until virsh -c qemu:///system domjobinfo $vm --completed 2>/dev/null | grep "Completed" > /dev/null; do
sleep 5