From 19e855e5dca314ac119646da12029d843eba376a Mon Sep 17 00:00:00 2001
From: Jessica Wang <jessicawang@apache.org>
Date: Wed, 4 Dec 2013 14:10:24 -0800
Subject: [PATCH] CLOUDSTACK-5200: UI > Infrastructure > Sockets > listView >
 fix a bug that Hosts and Sockets displayed wrong number.

---
 ui/scripts/system.js | 40 ++++++++++++++++++++--------------------
 1 file changed, 20 insertions(+), 20 deletions(-)

diff --git a/ui/scripts/system.js b/ui/scripts/system.js
index 0d8784f5006..cdece2fdf68 100644
--- a/ui/scripts/system.js
+++ b/ui/scripts/system.js
@@ -392,19 +392,22 @@
                                     	var currentPage = 1;
                                     	var returnedHostCount = 0;
                                     	var returnedHostCpusocketsSum = 0;
-                                    	var returnedHostHavingCpusockets = true;
-                                    	                                                	
+                                    	                                              	
                                     	var callListHostsWithPage = function(setTotalHostCount) {                                                		
                                     		$.ajax({
                             					url: createURL('listHosts'),
                                         		async: false,
                                         		data: {
                                         			type: 'routing',
-                                        			hypervisortype: hypervisor.name,
+                                        			hypervisor: hypervisor.name,
                                         			page: currentPage,
                                         	        pagesize: pageSize //global variable
                                         		},
-                                        		success: function(json) {                                                      			
+                                        		success: function(json) {                                          			
+                                        			if (json.listhostsresponse.count == undefined) {                                        				
+                                        				return;
+                                        			}
+                                        			                                        			
                                         			if (setTotalHostCount) {
                                         				totalHostCount = json.listhostsresponse.count;
                                         			}                                                    			
@@ -414,9 +417,7 @@
                                         			for (var i = 0; i < items.length; i++) {
                                         				if (items[i].cpusockets != undefined && isNaN(items[i].cpusockets) == false) {
                                         					returnedHostCpusocketsSum += items[i].cpusockets;
-                                        				} else {
-                                        					returnedHostHavingCpusockets = false;
-                                        				}
+                                        				} 
                                         			}  
                                         			
                                         			if (returnedHostCount < totalHostCount) {
@@ -428,10 +429,8 @@
                                     	}
                                     	
                                     	callListHostsWithPage(true);
-                                    	
-                                    	if (returnedHostHavingCpusockets) {
-                                    		socketCount += returnedHostCpusocketsSum;
-                                    	}                                    	
+                                    	                                    	
+                                    	socketCount += returnedHostCpusocketsSum;                                    	                                    	
                                     })
                                 });
                             }
@@ -7496,19 +7495,22 @@
                                                 	var currentPage = 1;
                                                 	var returnedHostCount = 0;
                                                 	var returnedHostCpusocketsSum = 0;
-                                                	var returnedHostHavingCpusockets = true;
-                                                	                                                	
+                                                	                                                	                                                	
                                                 	var callListHostsWithPage = function(setTotalHostCount) {                                                		
                                                 		$.ajax({
                                         					url: createURL('listHosts'),
                                                     		async: false,
                                                     		data: {
                                                     			type: 'routing',
-                                                    			hypervisortype: hypervisor.name,
+                                                    			hypervisor: hypervisor.name,
                                                     			page: currentPage,
                                                     	        pagesize: pageSize //global variable
                                                     		},
-                                                    		success: function(json) {                                                      			
+                                                    		success: function(json) {   
+                                                    			if (json.listhostsresponse.count == undefined) {   
+                                                    				return;
+                                                    			}                                                    			
+                                                    			
                                                     			if (setTotalHostCount) {
                                                     				totalHostCount = json.listhostsresponse.count;
                                                     			}                                                    			
@@ -7518,9 +7520,7 @@
                                                     			for (var i = 0; i < items.length; i++) {
                                                     				if (items[i].cpusockets != undefined && isNaN(items[i].cpusockets) == false) {
                                                     					returnedHostCpusocketsSum += items[i].cpusockets;
-                                                    				} else {
-                                                    					returnedHostHavingCpusockets = false;
-                                                    				}
+                                                    				} 
                                                     			}  
                                                     			
                                                     			if (returnedHostCount < totalHostCount) {
@@ -7532,11 +7532,11 @@
                                                 	}
                                                 	
                                                 	callListHostsWithPage(true);
-                                                	                                         	
+                                                	                                        	
                                                     return {
                                                         hypervisor: hypervisor.name,
                                                         hosts: totalHostCount,
-                                                        sockets: (returnedHostHavingCpusockets? returnedHostCpusocketsSum : 'unknown')                                                    
+                                                        sockets: returnedHostCpusocketsSum                                                    
                                                     };
                                                 })
                                             });