From 1b79a8e1d64cb998a44e07a58c1f13b64eed97fe Mon Sep 17 00:00:00 2001 From: Rafael da Fonseca Date: Sun, 14 Jun 2015 21:28:48 +0200 Subject: [PATCH] Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE in EngineDataCenterVO.java Assert isn't used in prod runtime, null is checked in method Signed-off-by: Rohit Yadav This closes #447 --- .../engine/datacenter/entity/api/db/EngineDataCenterVO.java | 2 -- 1 file changed, 2 deletions(-) diff --git a/engine/orchestration/src/org/apache/cloudstack/engine/datacenter/entity/api/db/EngineDataCenterVO.java b/engine/orchestration/src/org/apache/cloudstack/engine/datacenter/entity/api/db/EngineDataCenterVO.java index 82b6150a5a3..ca9ad50b3c1 100644 --- a/engine/orchestration/src/org/apache/cloudstack/engine/datacenter/entity/api/db/EngineDataCenterVO.java +++ b/engine/orchestration/src/org/apache/cloudstack/engine/datacenter/entity/api/db/EngineDataCenterVO.java @@ -402,8 +402,6 @@ public class EngineDataCenterVO implements EngineDataCenter, Identity { } public String getDetail(String name) { - assert (details != null) : "Did you forget to load the details?"; - return details != null ? details.get(name) : null; }