From 1bd3286263f973380d3f411fc9d667ecc974b385 Mon Sep 17 00:00:00 2001 From: Rafael da Fonseca Date: Sun, 14 Jun 2015 17:48:48 +0200 Subject: [PATCH] Fix 2 findbugs warnings in ApiResponseHelper.java ints were being boxed just to call .toString() Signed-off-by: Rohit Yadav This closes #438 --- server/src/com/cloud/api/ApiResponseHelper.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/server/src/com/cloud/api/ApiResponseHelper.java b/server/src/com/cloud/api/ApiResponseHelper.java index d904e73fcd8..99a80f8a44f 100644 --- a/server/src/com/cloud/api/ApiResponseHelper.java +++ b/server/src/com/cloud/api/ApiResponseHelper.java @@ -408,7 +408,7 @@ public class ApiResponseHelper implements ResponseGenerator { populateAccount(resourceLimitResponse, limit.getOwnerId()); populateDomain(resourceLimitResponse, accountTemp.getDomainId()); } - resourceLimitResponse.setResourceType(Integer.valueOf(limit.getType().getOrdinal()).toString()); + resourceLimitResponse.setResourceType(Integer.toString(limit.getType().getOrdinal())); if ((limit.getType() == ResourceType.primary_storage || limit.getType() == ResourceType.secondary_storage) && limit.getMax() >= 0) { resourceLimitResponse.setMax((long)Math.ceil((double)limit.getMax() / ResourceType.bytesToGiB)); @@ -434,7 +434,7 @@ public class ApiResponseHelper implements ResponseGenerator { populateDomain(resourceCountResponse, resourceCount.getOwnerId()); } - resourceCountResponse.setResourceType(Integer.valueOf(resourceCount.getType().getOrdinal()).toString()); + resourceCountResponse.setResourceType(Integer.toString(resourceCount.getType().getOrdinal())); resourceCountResponse.setResourceCount(resourceCount.getCount()); resourceCountResponse.setObjectName("resourcecount"); return resourceCountResponse;