From 1cf165f86df718bdbd1db1f094a341c8abaca42e Mon Sep 17 00:00:00 2001 From: Rohit Yadav Date: Thu, 5 Feb 2015 17:02:30 +0530 Subject: [PATCH] ApiResponseHelper: fix NPE when parent of snapshot is null --- server/src/com/cloud/api/ApiResponseHelper.java | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/server/src/com/cloud/api/ApiResponseHelper.java b/server/src/com/cloud/api/ApiResponseHelper.java index b8d4b3f541b..a13e9969423 100755 --- a/server/src/com/cloud/api/ApiResponseHelper.java +++ b/server/src/com/cloud/api/ApiResponseHelper.java @@ -500,7 +500,10 @@ public class ApiResponseHelper implements ResponseGenerator { vmSnapshotResponse.setVirtualMachineid(vm.getUuid()); } if (vmSnapshot.getParent() != null) { - vmSnapshotResponse.setParentName(ApiDBUtils.getVMSnapshotById(vmSnapshot.getParent()).getDisplayName()); + VMSnapshot vmSnapshotParent = ApiDBUtils.getVMSnapshotById(vmSnapshot.getParent()); + if (vmSnapshotParent != null) { + vmSnapshotResponse.setParentName(vmSnapshotParent.getDisplayName()); + } } vmSnapshotResponse.setCurrent(vmSnapshot.getCurrent()); vmSnapshotResponse.setType(vmSnapshot.getType().toString());