From 1f09b8c3bfdfee559d1735c8796daae16bf19e74 Mon Sep 17 00:00:00 2001
From: Maneesha P <maneesha.papireddygari@citrix.com>
Date: Thu, 23 Jul 2015 00:45:00 +0530
Subject: [PATCH] Fixed Coverity issue "Dereference null return value"

added a not null check and a CloudRuntimeException in case of null

Signed-off-by: Rajani Karuturi <rajanikaruturi@gmail.com>

This closes #617
---
 .../wrapper/LibvirtBackupSnapshotCommandWrapper.java      | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtBackupSnapshotCommandWrapper.java b/plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtBackupSnapshotCommandWrapper.java
index 25da0468dea..ad33945498a 100644
--- a/plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtBackupSnapshotCommandWrapper.java
+++ b/plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtBackupSnapshotCommandWrapper.java
@@ -171,7 +171,11 @@ public final class LibvirtBackupSnapshotCommandWrapper extends CommandWrapper<Ba
                 final String snapshot = snapshotXML.format(args);
                 s_logger.debug(snapshot);
                 final DomainSnapshot snap = vm.snapshotLookupByName(snapshotName);
-                snap.delete(0);
+                if (snap != null) {
+                    snap.delete(0);
+                } else {
+                    throw new CloudRuntimeException("Unable to find vm snapshot with name -" + snapshotName);
+                }
 
                 /*
                  * libvirt on RHEL6 doesn't handle resume event emitted from
@@ -203,4 +207,4 @@ public final class LibvirtBackupSnapshotCommandWrapper extends CommandWrapper<Ba
         }
         return new BackupSnapshotAnswer(command, true, null, snapshotRelPath + File.separator + snapshotName, true);
     }
-}
\ No newline at end of file
+}