From 20d3c62e44b518e39315327c52c616ed9220c1c3 Mon Sep 17 00:00:00 2001
From: Hoang Nguyen <hoangnm@unitech.vn>
Date: Thu, 18 Jun 2020 17:21:28 +0700
Subject: [PATCH] network: Acquire public IP address does not give IP selection
 option (#423)

Fixes  #392

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
---
 ui/src/locales/en.json                  |   1 +
 ui/src/views/network/IpAddressesTab.vue | 218 ++++++++++++++++--------
 2 files changed, 151 insertions(+), 68 deletions(-)

diff --git a/ui/src/locales/en.json b/ui/src/locales/en.json
index 7d7c04eb8a0..cfc82120c3d 100644
--- a/ui/src/locales/en.json
+++ b/ui/src/locales/en.json
@@ -2142,6 +2142,7 @@
 "message.acquire.new.ip": "Please confirm that you would like to acquire a new IP for this network.",
 "message.acquire.new.ip.vpc": "Please confirm that you would like to acquire a new IP for this VPC.",
 "message.acquire.public.ip": "Please select a zone from which you want to acquire your new IP from.",
+"message.action.acquire.ip": "Please confirm that you want to acquire new IP",
 "message.action.cancel.maintenance": "Your host has been successfully canceled for maintenance. This process can take up to several minutes.",
 "message.action.cancel.maintenance.mode": "Please confirm that you want to cancel this maintenance.",
 "message.action.change.service.warning.for.instance": "Your instance must be stopped before attempting to change its current service offering.",
diff --git a/ui/src/views/network/IpAddressesTab.vue b/ui/src/views/network/IpAddressesTab.vue
index 12fec6ea26d..f08982c4d4e 100644
--- a/ui/src/views/network/IpAddressesTab.vue
+++ b/ui/src/views/network/IpAddressesTab.vue
@@ -16,75 +16,105 @@
 // under the License.
 
 <template>
-  <a-spin :spinning="fetchLoading">
-    <a-button :disabled="!('associateIpAddress' in $store.getters.apis)" type="dashed" icon="plus" style="width: 100%; margin-bottom: 15px" @click="acquireIpAddress">
-      {{ $t('label.acquire.new.ip') }}
-    </a-button>
-    <div v-if="$route.path.startsWith('/vpc')">
-      Select Tier:
-      <a-select
-        style="width: 40%; margin-left: 15px;margin-bottom: 15px"
-        :loading="fetchLoading"
-        defaultActiveFirstOption
-        :value="vpcTier"
-        @change="handleTierSelect"
-      >
-        <a-select-option key="all" value="">
-          {{ $t('label.view.all') }}
-        </a-select-option>
-        <a-select-option v-for="network in networksList" :key="network.id" :value="network.id">
-          {{ network.name }}
-        </a-select-option>
-      </a-select>
-    </div>
-    <a-table
-      size="small"
-      style="overflow-y: auto"
-      :columns="columns"
-      :dataSource="ips"
-      :rowKey="item => item.id"
-      :pagination="false" >
-      <template slot="ipaddress" slot-scope="text, record">
-        <router-link :to="{ path: '/publicip/' + record.id }" >{{ text }} </router-link>
-        <a-tag v-if="record.issourcenat === true">source-nat</a-tag>
-      </template>
+  <div>
+    <a-spin :spinning="fetchLoading">
+      <a-button
+        :disabled="!('associateIpAddress' in $store.getters.apis)"
+        type="dashed"
+        icon="plus"
+        style="width: 100%; margin-bottom: 15px"
+        @click="onShowAcquireIp">
+        {{ $t('label.acquire.new.ip') }}
+      </a-button>
+      <div v-if="$route.path.startsWith('/vpc')">
+        Select Tier:
+        <a-select
+          style="width: 40%; margin-left: 15px;margin-bottom: 15px"
+          :loading="fetchLoading"
+          defaultActiveFirstOption
+          :value="vpcTier"
+          @change="handleTierSelect"
+        >
+          <a-select-option key="all" value="">
+            {{ $t('label.view.all') }}
+          </a-select-option>
+          <a-select-option v-for="network in networksList" :key="network.id" :value="network.id">
+            {{ network.name }}
+          </a-select-option>
+        </a-select>
+      </div>
+      <a-table
+        size="small"
+        style="overflow-y: auto"
+        :columns="columns"
+        :dataSource="ips"
+        :rowKey="item => item.id"
+        :pagination="false" >
+        <template slot="ipaddress" slot-scope="text, record">
+          <router-link :to="{ path: '/publicip/' + record.id }" >{{ text }} </router-link>
+          <a-tag v-if="record.issourcenat === true">source-nat</a-tag>
+        </template>
 
-      <template slot="state" slot-scope="text, record">
-        <status :text="record.state" displayText />
-      </template>
+        <template slot="state" slot-scope="text, record">
+          <status :text="record.state" displayText />
+        </template>
 
-      <template slot="virtualmachineid" slot-scope="text, record">
-        <a-icon type="desktop" v-if="record.virtualmachineid" />
-        <router-link :to="{ path: '/vm/' + record.virtualmachineid }" > {{ record.virtualmachinename || record.virtualmachineid }} </router-link>
-      </template>
+        <template slot="virtualmachineid" slot-scope="text, record">
+          <a-icon type="desktop" v-if="record.virtualmachineid" />
+          <router-link :to="{ path: '/vm/' + record.virtualmachineid }" > {{ record.virtualmachinename || record.virtualmachineid }} </router-link>
+        </template>
 
-      <template slot="associatednetworkname" slot-scope="text, record">
-        <router-link :to="{ path: '/guestnetwork/' + record.associatednetworkid }" > {{ record.associatednetworkname || record.associatednetworkid }} </router-link>
-      </template>
+        <template slot="associatednetworkname" slot-scope="text, record">
+          <router-link :to="{ path: '/guestnetwork/' + record.associatednetworkid }" > {{ record.associatednetworkname || record.associatednetworkid }} </router-link>
+        </template>
 
-      <template slot="action" slot-scope="text, record">
-        <a-button
-          v-if="record.issourcenat !== true"
-          type="danger"
-          icon="delete"
-          shape="circle"
-          :disabled="!('disassociateIpAddress' in $store.getters.apis)"
-          @click="releaseIpAddress(record)" />
-      </template>
-    </a-table>
-    <a-divider/>
-    <a-pagination
-      class="row-element pagination"
-      size="small"
-      :current="page"
-      :pageSize="pageSize"
-      :total="totalIps"
-      :showTotal="total => `Total ${total} items`"
-      :pageSizeOptions="['10', '20', '40', '80', '100']"
-      @change="changePage"
-      @showSizeChange="changePageSize"
-      showSizeChanger/>
-  </a-spin>
+        <template slot="action" slot-scope="text, record">
+          <a-button
+            v-if="record.issourcenat !== true"
+            type="danger"
+            icon="delete"
+            shape="circle"
+            :disabled="!('disassociateIpAddress' in $store.getters.apis)"
+            @click="releaseIpAddress(record)" />
+        </template>
+      </a-table>
+      <a-divider/>
+      <a-pagination
+        class="row-element pagination"
+        size="small"
+        :current="page"
+        :pageSize="pageSize"
+        :total="totalIps"
+        :showTotal="total => `Total ${total} items`"
+        :pageSizeOptions="['10', '20', '40', '80', '100']"
+        @change="changePage"
+        @showSizeChange="changePageSize"
+        showSizeChanger/>
+    </a-spin>
+    <a-modal
+      v-if="showAcquireIp"
+      :visible="showAcquireIp"
+      :title="$t('label.acquire.new.ip')"
+      :closable="true"
+      @cancel="onCloseModal"
+      @ok="acquireIpAddress"
+      centered
+      width="450px">
+      <a-spin :spinning="acquireLoading">
+        <a-alert :message="$t('message.action.acquire.ip')" type="warning" />
+        <a-form-item :label="$t('label.ipaddress')">
+          <a-select
+            style="width: 100%;"
+            showSearch
+            v-model="acquireIp">
+            <a-select-option
+              v-for="ip in listPublicIpAddress"
+              :key="ip.ipaddress">{{ ip.ipaddress }}</a-select-option>
+          </a-select>
+        </a-form-item>
+      </a-spin>
+    </a-modal>
+  </div>
 </template>
 <script>
 import { api } from '@/api'
@@ -142,7 +172,11 @@ export default {
           title: '',
           scopedSlots: { customRender: 'action' }
         }
-      ]
+      ],
+      showAcquireIp: false,
+      acquireLoading: false,
+      acquireIp: null,
+      listPublicIpAddress: []
     }
   },
   mounted () {
@@ -181,6 +215,21 @@ export default {
         this.fetchLoading = false
       })
     },
+    fetchListPublicIpAddress () {
+      return new Promise((resolve, reject) => {
+        const params = {
+          zoneid: this.resource.zoneid,
+          domainid: this.resource.domainid,
+          account: this.resource.account,
+          forvirtualnetwork: true,
+          allocatedonly: false
+        }
+        api('listPublicIpAddresses', params).then(json => {
+          const listPublicIps = json.listpublicipaddressesresponse.publicipaddress || []
+          resolve(listPublicIps)
+        }).catch(reject)
+      })
+    },
     handleTierSelect (tier) {
       this.vpcTier = tier
       this.fetchData()
@@ -205,7 +254,9 @@ export default {
       } else {
         params.networkid = this.resource.id
       }
-      this.fetchLoading = true
+      params.ipaddress = this.acquireIp
+      this.acquireLoading = true
+
       api('associateIpAddress', params).then(response => {
         this.$pollJob({
           jobId: response.associateipaddressresponse.jobid,
@@ -221,12 +272,14 @@ export default {
           catchMessage: 'Error encountered while fetching async job result'
         })
       }).catch(error => {
-        this.fetchLoading = false
         this.$notification.error({
           message: `Error ${error.response.status}`,
           description: error.response.data.errorresponse.errortext,
           duration: 0
         })
+      }).finally(() => {
+        this.acquireLoading = false
+        this.onCloseModal()
       })
     },
     releaseIpAddress (ip) {
@@ -255,6 +308,35 @@ export default {
           duration: 0
         })
       })
+    },
+    async onShowAcquireIp () {
+      this.showAcquireIp = true
+      this.acquireLoading = true
+      this.listPublicIpAddress = []
+
+      try {
+        const listPublicIpAddress = await this.fetchListPublicIpAddress()
+        listPublicIpAddress.forEach(item => {
+          if (item.state === 'Free') {
+            this.listPublicIpAddress.push({
+              ipaddress: item.ipaddress
+            })
+          }
+        })
+        this.listPublicIpAddress.sort(function (a, b) {
+          if (a.ipaddress < b.ipaddress) { return -1 }
+          if (a.ipaddress > b.ipaddress) { return 1 }
+          return 0
+        })
+        this.acquireIp = this.listPublicIpAddress && this.listPublicIpAddress.length > 0 ? this.listPublicIpAddress[0].ipaddress : null
+        this.acquireLoading = false
+      } catch (e) {
+        this.acquireLoading = false
+        this.$notifyError(e)
+      }
+    },
+    onCloseModal () {
+      this.showAcquireIp = false
     }
   }
 }