From a6e8cfde3f3049a7a68c049a45ce225b9f47e178 Mon Sep 17 00:00:00 2001 From: Rohit Yadav Date: Thu, 27 Aug 2015 12:31:04 +0530 Subject: [PATCH] CLOUDSTACK-8766: Fix infinite scrolling pagination for zonal iso/template listing Due to aggregation of templates and isos on the UI/client side, it could result that for each page we could end up having lesser templates/isos listed to have the scroll shown that triggers infinite scrolling. In theory, there is still a chance if there are several zones with the same template being listed resulting in only one aggregated template which could cause the scroll to not get shown; but in practice I believe this fix should work for most users. Page size set based on experimental data: https://github.com/apache/cloudstack/pull/751#issuecomment-135661968 Signed-off-by: Rohit Yadav --- ui/scripts/templates.js | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/ui/scripts/templates.js b/ui/scripts/templates.js index 48f06fd3d3b..ac739c631e4 100644 --- a/ui/scripts/templates.js +++ b/ui/scripts/templates.js @@ -879,6 +879,10 @@ dataProvider: function(args) { var data = {}; listViewDataProvider(args, data); + // Due to zonal grouping, low pagesize can result lower + // aggregated items, resulting in no scroll shown + // So, use maximum pagesize + data.pagesize = 200; var ignoreProject = false; if (args.filterBy != null) { //filter dropdown @@ -2024,6 +2028,10 @@ dataProvider: function(args) { var data = {}; listViewDataProvider(args, data); + // Due to zonal grouping, low pagesize can result lower + // aggregated items, resulting in no scroll shown + // So, use maximum pagesize + data.pagesize = 200; var ignoreProject = false; if (args.filterBy != null) { //filter dropdown