From 22bca0c248ff23ba4183b4db8099bcf66c0a6362 Mon Sep 17 00:00:00 2001
From: Philipp Bankonier <p.bankonier@ewerk.com>
Date: Thu, 12 Sep 2019 19:28:47 +0200
Subject: [PATCH] Enhancement/linting (#34)

* Stop emitting lint errors as warnings

* Execute lint on inital serve for development

* Fix linting errors

* Fix linting warnings

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
---
 ui/package.json                            |  4 +--
 ui/src/components/CloudMonkey/Resource.vue | 32 +++++++++++-----------
 ui/src/components/widgets/InstanceView.vue |  7 ++---
 ui/vue.config.js                           |  5 ++++
 4 files changed, 25 insertions(+), 23 deletions(-)

diff --git a/ui/package.json b/ui/package.json
index b2b719fe9ae..86ef22d45aa 100644
--- a/ui/package.json
+++ b/ui/package.json
@@ -3,8 +3,8 @@
   "version": "1.3.0",
   "private": true,
   "scripts": {
-    "start": "vue-cli-service serve",
-    "serve": "vue-cli-service serve",
+    "start": "vue-cli-service lint --no-fix && vue-cli-service serve",
+    "serve": "vue-cli-service lint --no-fix && vue-cli-service serve",
     "build": "vue-cli-service build",
     "lint": "vue-cli-service lint",
     "i18n:report": "vue-cli-service i18n:report --src './src/**/*.?(js|vue)' --locales './src/locales/**/*.json'",
diff --git a/ui/src/components/CloudMonkey/Resource.vue b/ui/src/components/CloudMonkey/Resource.vue
index cb964bde8dd..be8e9657da4 100644
--- a/ui/src/components/CloudMonkey/Resource.vue
+++ b/ui/src/components/CloudMonkey/Resource.vue
@@ -2,22 +2,22 @@
   <div>
     <a-breadcrumb class="breadcrumb" v-if="device !== 'desktop'" style="margin-left: -16px; margin-right: -16px; margin-top: -16px">
       <a-card :bordered="true">
-      <a-breadcrumb-item v-for="(item, index) in breadList" :key="index">
-        <router-link
-          v-if="item.name"
-          :to="{ path: item.path === '' ? '/' : item.path }"
-        >
-          <a-icon v-if="index == 0" :type="item.meta.icon" />
-          {{ $t(item.meta.title) }}
-        </router-link>
-        <span v-else-if="$route.params.id">
-          {{ $route.params.id }}
-          <a-button shape="circle" type="dashed" size="small" v-clipboard:copy="$route.params.id">
-            <a-icon type="copy" style="margin-left: 0px"/>
-          </a-button>
-        </span>
-        <span v-else>{{ $t(tem.meta.title) }}</span>
-      </a-breadcrumb-item>
+        <a-breadcrumb-item v-for="(item, index) in breadList" :key="index">
+          <router-link
+            v-if="item.name"
+            :to="{ path: item.path === '' ? '/' : item.path }"
+          >
+            <a-icon v-if="index == 0" :type="item.meta.icon" />
+            {{ $t(item.meta.title) }}
+          </router-link>
+          <span v-else-if="$route.params.id">
+            {{ $route.params.id }}
+            <a-button shape="circle" type="dashed" size="small" v-clipboard:copy="$route.params.id">
+              <a-icon type="copy" style="margin-left: 0px"/>
+            </a-button>
+          </span>
+          <span v-else>{{ $t(tem.meta.title) }}</span>
+        </a-breadcrumb-item>
       </a-card>
     </a-breadcrumb>
 
diff --git a/ui/src/components/widgets/InstanceView.vue b/ui/src/components/widgets/InstanceView.vue
index cf9fab2d09e..f2963486ebd 100644
--- a/ui/src/components/widgets/InstanceView.vue
+++ b/ui/src/components/widgets/InstanceView.vue
@@ -23,7 +23,7 @@
           </div>
           <div class="account-center-detail">
             <p>
-              <status :text="vm.state" style="padding-left: 8px; padding-right: 5px"/>{{ vm.state}}
+              <status :text="vm.state" style="padding-left: 8px; padding-right: 5px"/>{{ vm.state }}
             </p>
             <p>
               <font-awesome-icon :icon="['fab', osLogo]" size="lg"/> {{ guestOsName }} <br/>
@@ -146,7 +146,7 @@
           @tabChange="key => handleTabChange(key, 'noTitleKey')"
         >
           <span slot="customRender" slot-scope="item">
-            <a-icon type="home"/>{{item.tab}}
+            <a-icon type="home"/>{{ item.tab }}
           </span>
           <a-collapse v-model="activeKey">
             <a-collapse-panel :header="'ISO: ' + vm.isoname" v-if="vm.isoid" key="1">
@@ -222,7 +222,6 @@
             </a-collapse-panel>
           </a-collapse>
 
-
         </a-card>
       </a-col>
     </a-row>
@@ -252,11 +251,9 @@ export default {
       totalStorage: 0,
       guestOsName: '',
       osLogo: 'linux',
-      tags: [],
       inputVisible: false,
       inputValue: '',
       activeKey: ['1', '2', '3'],
-
       tags: ['os=centos', 'tag=value', 'demo=true'],
       tagInputVisible: false,
       tagInputValue: '',
diff --git a/ui/vue.config.js b/ui/vue.config.js
index 98b19720a8c..6db2c4a77be 100644
--- a/ui/vue.config.js
+++ b/ui/vue.config.js
@@ -38,6 +38,11 @@ module.exports = {
       .set('@layout', resolve('src/layout'))
       .set('@static', resolve('src/static'))
 
+    // do not emit errors as a warning
+    config.module.rule('eslint').use('eslint-loader').tap(
+      opts => ({ ...opts, emitWarning: false })
+    )
+
     const svgRule = config.module.rule('svg')
     svgRule.uses.clear()
     svgRule