From 66fc7c62f4b21e770ecc6d6dfa99b3b06f410e89 Mon Sep 17 00:00:00 2001 From: Wei Zhou Date: Wed, 11 Nov 2015 12:18:54 +0100 Subject: [PATCH] CLOUDSTACK-9055: fix NPE in updating Redundant State of VPC networks --- .../router/VirtualNetworkApplianceManagerImpl.java | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java b/server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java index f0e5f0916b9..ca1f67dbb69 100644 --- a/server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java +++ b/server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java @@ -1013,10 +1013,12 @@ Configurable, StateListener { s_logger.warn("Unable to update router " + router.getHostName() + "'s status"); } RedundantState state = RedundantState.UNKNOWN; - if (answer != null && answer.getResult()) { - state = answer.getState(); - } else { - s_logger.info("Agent response doesn't seem to be correct ==> " + answer.getResult()); + if (answer != null) { + if (answer.getResult()) { + state = answer.getState(); + } else { + s_logger.info("Agent response doesn't seem to be correct ==> " + answer.getResult()); + } } router.setRedundantState(state); updated = true;