From 2424d9a9e0f1189044303a98c40e60033808f0b2 Mon Sep 17 00:00:00 2001 From: Rajani Karuturi Date: Tue, 3 Jun 2014 12:31:20 +0530 Subject: [PATCH] Fixed ResouceLeak on pstmtCidr in the function Upgrade430to440.moveCidrsToTheirOwnTable as reported by coverity Signed-off-by: Hugo Trippaers --- .../src/com/cloud/upgrade/dao/Upgrade430to440.java | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/engine/schema/src/com/cloud/upgrade/dao/Upgrade430to440.java b/engine/schema/src/com/cloud/upgrade/dao/Upgrade430to440.java index 351b74aed18..7fe285feb8d 100644 --- a/engine/schema/src/com/cloud/upgrade/dao/Upgrade430to440.java +++ b/engine/schema/src/com/cloud/upgrade/dao/Upgrade430to440.java @@ -254,14 +254,12 @@ public class Upgrade430to440 implements DbUpgrade { String[] cidrArray = cidrList.split(","); // insert a record per cidr String networkAclItemCidrSql = "INSERT INTO `cloud`.`network_acl_item_cidrs` (network_acl_item_id, cidr) VALUES (?,?)"; - for(String cidr: cidrArray) - { - pstmtCidr = conn.prepareStatement(networkAclItemCidrSql); - pstmtCidr.setLong(1,itemId); - pstmtCidr.setString(2,cidr); + pstmtCidr = conn.prepareStatement(networkAclItemCidrSql); + pstmtCidr.setLong(1, itemId); + for (String cidr : cidrArray) { + pstmtCidr.setString(2, cidr); pstmtCidr.executeUpdate(); } - pstmtCidr.close(); } } catch (SQLException e) { throw new CloudRuntimeException("Exception while Moving network acl item cidrs to a row per cidr", e);