diff --git a/plugins/network-elements/bigswitch-vns/src/com/cloud/network/guru/BigSwitchVnsGuestNetworkGuru.java b/plugins/network-elements/bigswitch-vns/src/com/cloud/network/guru/BigSwitchVnsGuestNetworkGuru.java index 48233c488c3..daf65a12fc8 100644 --- a/plugins/network-elements/bigswitch-vns/src/com/cloud/network/guru/BigSwitchVnsGuestNetworkGuru.java +++ b/plugins/network-elements/bigswitch-vns/src/com/cloud/network/guru/BigSwitchVnsGuestNetworkGuru.java @@ -165,6 +165,8 @@ public class BigSwitchVnsGuestNetworkGuru extends GuestNetworkGuru { throw new InsufficientVirtualNetworkCapcityException("Unable to allocate vnet as a " + "part of network " + network + " implement ", DataCenter.class, dcId); } + // when supporting more types of networks this need to become +// int vlan = Integer.parseInt(BroadcastDomainType.getValue(vnet)); int vlan = Integer.parseInt(vnet); // Name is either the given name or the uuid diff --git a/plugins/network-elements/juniper-srx/src/com/cloud/network/resource/JuniperSrxResource.java b/plugins/network-elements/juniper-srx/src/com/cloud/network/resource/JuniperSrxResource.java index 3bcbf2df079..46ef332d3a7 100644 --- a/plugins/network-elements/juniper-srx/src/com/cloud/network/resource/JuniperSrxResource.java +++ b/plugins/network-elements/juniper-srx/src/com/cloud/network/resource/JuniperSrxResource.java @@ -65,6 +65,7 @@ import com.cloud.agent.api.to.IpAddressTO; import com.cloud.agent.api.to.PortForwardingRuleTO; import com.cloud.agent.api.to.StaticNatRuleTO; import com.cloud.host.Host; +import com.cloud.network.Networks.BroadcastDomainType; import com.cloud.network.rules.FirewallRule; import com.cloud.network.rules.FirewallRule.Purpose; import com.cloud.resource.ServerResource; @@ -698,8 +699,7 @@ public class JuniperSrxResource implements ServerResource { Long publicVlanTag = null; if (ip.getVlanId() != null && !ip.getVlanId().equals("untagged")) { try { - // TODO BroadcastDomain.getValue(ip.getVlanId) ??? - publicVlanTag = Long.parseLong(ip.getVlanId()); + publicVlanTag = Long.parseLong(BroadcastDomainType.getValue(ip.getVlanId())); } catch (Exception e) { throw new ExecutionException("Could not parse public VLAN tag: " + ip.getVlanId()); } @@ -3581,7 +3581,8 @@ public class JuniperSrxResource implements ServerResource { Long publicVlanTag = null; if (!vlan.equals("untagged")) { try { - publicVlanTag = Long.parseLong(vlan); + // make sure this vlan is numeric + publicVlanTag = Long.parseLong(BroadcastDomainType.getValue(vlan)); } catch (Exception e) { throw new ExecutionException("Unable to parse VLAN tag: " + vlan); } diff --git a/server/src/com/cloud/network/guru/ExternalGuestNetworkGuru.java b/server/src/com/cloud/network/guru/ExternalGuestNetworkGuru.java index 79a4053d09f..55a33ccce71 100644 --- a/server/src/com/cloud/network/guru/ExternalGuestNetworkGuru.java +++ b/server/src/com/cloud/network/guru/ExternalGuestNetworkGuru.java @@ -143,6 +143,8 @@ public class ExternalGuestNetworkGuru extends GuestNetworkGuru { UseSystemGuestVlans.valueIn(config.getAccountId())); try { + // when supporting more types of networks this need to become +// int vlantag = Integer.parseInt(BroadcastDomainType.getValue(vnet)); vlanTag = Integer.parseInt(vnet); } catch (NumberFormatException e) { throw new CloudRuntimeException("Obtained an invalid guest vlan tag. Exception: " + e.getMessage()); diff --git a/vmware-base/src/com/cloud/hypervisor/vmware/mo/HypervisorHostHelper.java b/vmware-base/src/com/cloud/hypervisor/vmware/mo/HypervisorHostHelper.java index 1cd1deb8efb..ac34b490be9 100755 --- a/vmware-base/src/com/cloud/hypervisor/vmware/mo/HypervisorHostHelper.java +++ b/vmware-base/src/com/cloud/hypervisor/vmware/mo/HypervisorHostHelper.java @@ -499,10 +499,10 @@ public class HypervisorHostHelper { if(vlanId != null && !UNTAGGED_VLAN_NAME.equalsIgnoreCase(vlanId)) { createGCTag = true; - vid = Integer.parseInt(vlanId); + vid = Integer.parseInt(BroadcastDomainType.getValue(vlanId)); } if (secondaryvlanId != null) { - spvlanid = Integer.parseInt(secondaryvlanId); + spvlanid = Integer.parseInt(BroadcastDomainType.getValue(secondaryvlanId)); } } @@ -937,7 +937,7 @@ public class HypervisorHostHelper { if(vlanId != null && !UNTAGGED_VLAN_NAME.equalsIgnoreCase(vlanId) ) { createGCTag = true; - vid = Integer.parseInt(vlanId); + vid = Integer.parseInt(BroadcastDomainType.getValue(vlanId)); } }