From 2bdc45375e77f3837a290c65334403af3258f470 Mon Sep 17 00:00:00 2001 From: edison Date: Wed, 13 Oct 2010 19:10:13 -0700 Subject: [PATCH] fix a funny bug that integer left shift more than 32 bit, you will get a wrap around --- core/src/com/cloud/agent/transport/Request.java | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/core/src/com/cloud/agent/transport/Request.java b/core/src/com/cloud/agent/transport/Request.java index 3910ade0164..e22f5ee006c 100755 --- a/core/src/com/cloud/agent/transport/Request.java +++ b/core/src/com/cloud/agent/transport/Request.java @@ -158,11 +158,11 @@ public class Request { } private final void setRevertOnError(boolean revertOnError) { - _flags |= (revertOnError ? 1 : 0) << FLAG_REVERT_ON_ERROR; + _flags |= (revertOnError ? FLAG_REVERT_ON_ERROR : 0); } - private final void setFromServer(boolean fromServer) { - _flags |= (fromServer ? 1 : 0) << FLAG_FROM_SERVER; + private final void setFromServer(boolean fromServer) { + _flags |= (fromServer ? FLAG_FROM_SERVER : 0); } public long getManagementServerId() {