From 2c4ac5e4d3392da6b9be5979b49d94650e9f3b1a Mon Sep 17 00:00:00 2001 From: Laszlo Hornyak Date: Fri, 21 Mar 2014 21:52:06 +0100 Subject: [PATCH] removed some redundant Boolean isntantiations Signed-off-by: Laszlo Hornyak --- .../src/com/cloud/vm/VirtualMachineManagerImpl.java | 4 ++-- server/src/com/cloud/api/ApiServer.java | 2 +- server/src/com/cloud/resource/ResourceManagerImpl.java | 4 ++-- server/src/com/cloud/storage/upload/UploadMonitorImpl.java | 2 +- server/src/com/cloud/vm/snapshot/VMSnapshotManagerImpl.java | 4 ++-- 5 files changed, 8 insertions(+), 8 deletions(-) diff --git a/engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java b/engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java index 2ff870aed67..bbd49f2cfdc 100755 --- a/engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java +++ b/engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java @@ -5238,7 +5238,7 @@ public class VirtualMachineManagerImpl extends ManagerBase implements VirtualMac NicVO nic = _entityMgr.findById(NicVO.class, work.getNicId()); boolean result = orchestrateRemoveNicFromVm(vm, nic); return new Pair(JobInfo.Status.SUCCEEDED, - _jobMgr.marshallResultObject(new Boolean(result))); + _jobMgr.marshallResultObject(result)); } private Pair orchestrateRemoveVmFromNetwork(VmWorkRemoveVmFromNetwork work) throws Exception { @@ -5250,7 +5250,7 @@ public class VirtualMachineManagerImpl extends ManagerBase implements VirtualMac boolean result = orchestrateRemoveVmFromNetwork(vm, work.getNetwork(), work.getBroadcastUri()); return new Pair(JobInfo.Status.SUCCEEDED, - _jobMgr.marshallResultObject(new Boolean(result))); + _jobMgr.marshallResultObject(result)); } private Pair orchestrateReconfigure(VmWorkReconfigure work) throws Exception { diff --git a/server/src/com/cloud/api/ApiServer.java b/server/src/com/cloud/api/ApiServer.java index e4486c1fee7..bde3f24639b 100755 --- a/server/src/com/cloud/api/ApiServer.java +++ b/server/src/com/cloud/api/ApiServer.java @@ -885,7 +885,7 @@ public class ApiServer extends ManagerBase implements HttpRequestHandler, ApiSer session.setAttribute("type", Short.valueOf(account.getType()).toString()); session.setAttribute("registrationtoken", userAcct.getRegistrationToken()); - session.setAttribute("registered", new Boolean(userAcct.isRegistered()).toString()); + session.setAttribute("registered", Boolean.toString(userAcct.isRegistered())); if (timezone != null) { session.setAttribute("timezone", timezone); diff --git a/server/src/com/cloud/resource/ResourceManagerImpl.java b/server/src/com/cloud/resource/ResourceManagerImpl.java index f9a59ba4eb8..d822c2456b5 100755 --- a/server/src/com/cloud/resource/ResourceManagerImpl.java +++ b/server/src/com/cloud/resource/ResourceManagerImpl.java @@ -816,8 +816,8 @@ public class ResourceManagerImpl extends ManagerBase implements ResourceManager, final List pools = _storagePoolHostDao.listByHostIdIncludingRemoved(hostId); ResourceStateAdapter.DeleteHostAnswer answer = - (ResourceStateAdapter.DeleteHostAnswer)dispatchToStateAdapters(ResourceStateAdapter.Event.DELETE_HOST, false, host, new Boolean(isForced), new Boolean( - isForceDeleteStorage)); + (ResourceStateAdapter.DeleteHostAnswer)dispatchToStateAdapters(ResourceStateAdapter.Event.DELETE_HOST, false, host, isForced, + isForceDeleteStorage); if (answer == null) { throw new CloudRuntimeException("No resource adapter respond to DELETE_HOST event for " + host.getName() + " id = " + hostId + ", hypervisorType is " + diff --git a/server/src/com/cloud/storage/upload/UploadMonitorImpl.java b/server/src/com/cloud/storage/upload/UploadMonitorImpl.java index 8a997b2afec..35cb665e667 100755 --- a/server/src/com/cloud/storage/upload/UploadMonitorImpl.java +++ b/server/src/com/cloud/storage/upload/UploadMonitorImpl.java @@ -104,7 +104,7 @@ public class UploadMonitorImpl extends ManagerBase implements UploadMonitor { @Inject private DataStoreManager storeMgr; - private Boolean _sslCopy = new Boolean(false); + private boolean _sslCopy = false; private String _ssvmUrlDomain; private ScheduledExecutorService _executor = null; diff --git a/server/src/com/cloud/vm/snapshot/VMSnapshotManagerImpl.java b/server/src/com/cloud/vm/snapshot/VMSnapshotManagerImpl.java index 37cdf86fd43..b30fd140576 100644 --- a/server/src/com/cloud/vm/snapshot/VMSnapshotManagerImpl.java +++ b/server/src/com/cloud/vm/snapshot/VMSnapshotManagerImpl.java @@ -1053,7 +1053,7 @@ public class VMSnapshotManagerImpl extends ManagerBase implements VMSnapshotMana public Pair orchestrateDeleteVMSnapshot(VmWorkDeleteVMSnapshot work) { boolean result = orchestrateDeleteVMSnapshot(work.getVmSnapshotId()); return new Pair(JobInfo.Status.SUCCEEDED, - _jobMgr.marshallResultObject(new Boolean(result))); + _jobMgr.marshallResultObject(result)); } public Pair orchestrateRevertToVMSnapshot(VmWorkRevertToVMSnapshot work) throws Exception { @@ -1064,7 +1064,7 @@ public class VMSnapshotManagerImpl extends ManagerBase implements VMSnapshotMana public Pair orchestrateDeleteAllVMSnapshots(VmWorkDeleteAllVMSnapshots work) { boolean result = orchestrateDeleteAllVMSnapshots(work.getVmId(), work.getSnapshotType()); return new Pair(JobInfo.Status.SUCCEEDED, - _jobMgr.marshallResultObject(new Boolean(result))); + _jobMgr.marshallResultObject(result)); } @Override