From 329b3a5611013025791f6b814546230799b21978 Mon Sep 17 00:00:00 2001
From: Daan Hoogland <daan@onecht.net>
Date: Thu, 26 Nov 2015 21:24:52 +0100
Subject: [PATCH] CID-1339965 handle retrun value on failure

---
 .../cloudstack/storage/template/DownloadManagerImpl.java      | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/services/secondary-storage/server/src/org/apache/cloudstack/storage/template/DownloadManagerImpl.java b/services/secondary-storage/server/src/org/apache/cloudstack/storage/template/DownloadManagerImpl.java
index 8c474caa708..9cf37e56596 100644
--- a/services/secondary-storage/server/src/org/apache/cloudstack/storage/template/DownloadManagerImpl.java
+++ b/services/secondary-storage/server/src/org/apache/cloudstack/storage/template/DownloadManagerImpl.java
@@ -558,7 +558,9 @@ public class DownloadManagerImpl extends ManagerBase implements DownloadManager
                     ResourceType.TEMPLATE == resourceType ? _storage.getFile(tmpDir + File.separator + TemplateLocation.Filename) : _storage.getFile(tmpDir + File.separator +
                             "volume.properties");
                     if (file.exists()) {
-                        file.delete();
+                        if(! file.delete()) {
+                            s_logger.warn("Deletion of file '" + file.getAbsolutePath() + "' failed.");
+                        }
                     }
 
                     if (!file.createNewFile()) {