Apply suggestions from code review

Co-authored-by: dahn <daan.hoogland@gmail.com>
This commit is contained in:
dahn 2026-05-26 11:50:34 +02:00 committed by GitHub
parent 10a04048ab
commit 32e59515ed
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 9 additions and 11 deletions

View File

@ -113,16 +113,15 @@ class TestDeployVMFromISO(cloudstackTestCase):
self.cleanup.append(self.iso)
self.debug("ISO created with ID: %s" % self.iso.id)
list_iso_response = Iso.list(
self.apiclient,
id=self.iso.id
)
self.assertEqual(
isinstance(list_iso_response, list),
True,
"Check list response returns a valid list"
)
while not isinstance(list_iso_response, list):
list_iso_response = Iso.list(
self.apiclient,
id=self.iso.id
)
try:
# Download the ISO
@ -163,11 +162,10 @@ class TestDeployVMFromISO(cloudstackTestCase):
VirtualMachine.RUNNING
)
self.assertEqual(
vm_state,
VirtualMachine.RUNNING,
"Check virtual machine is in running state"
)
response = self.virtual_machine.getState(
self.apiclient,
VirtualMachine.RUNNING)
self.assertEqual(response[0], PASS, response[1])
self.assertEqual(
vm_response.isoid,