From 36efe4dbf4e5d24c27f25a1f8057f1004d69c12f Mon Sep 17 00:00:00 2001 From: edison Date: Wed, 8 Jan 2014 17:07:45 -0800 Subject: [PATCH] CLOUDSTACK-5831: Fix NPE, in case the volume isn't attached to any pool --- server/src/com/cloud/api/query/QueryManagerImpl.java | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/server/src/com/cloud/api/query/QueryManagerImpl.java b/server/src/com/cloud/api/query/QueryManagerImpl.java index 9d5914d7eb6..f2c73462701 100644 --- a/server/src/com/cloud/api/query/QueryManagerImpl.java +++ b/server/src/com/cloud/api/query/QueryManagerImpl.java @@ -1642,6 +1642,10 @@ public class QueryManagerImpl extends ManagerBase implements QueryService { for(VolumeResponse vr : volumeResponses) { String poolId = vr.getStoragePoolId(); + if (poolId == null) { + continue; + } + DataStore store = dataStoreManager.getPrimaryDataStore(poolId); if (store == null) { continue;