From 37c4015d4dd3786496331db44cf65b12df9d50f2 Mon Sep 17 00:00:00 2001 From: Jayapal Date: Mon, 10 Feb 2014 14:27:46 +0530 Subject: [PATCH] CLOUDSTACK-6040: Updated the ip addr validation in create port forwarding --- .../api/command/user/firewall/CreatePortForwardingRuleCmd.java | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/api/src/org/apache/cloudstack/api/command/user/firewall/CreatePortForwardingRuleCmd.java b/api/src/org/apache/cloudstack/api/command/user/firewall/CreatePortForwardingRuleCmd.java index 89dc0772562..de8237749ba 100644 --- a/api/src/org/apache/cloudstack/api/command/user/firewall/CreatePortForwardingRuleCmd.java +++ b/api/src/org/apache/cloudstack/api/command/user/firewall/CreatePortForwardingRuleCmd.java @@ -18,6 +18,7 @@ package org.apache.cloudstack.api.command.user.firewall; import java.util.List; +import com.cloud.utils.net.NetUtils; import org.apache.log4j.Logger; import org.apache.cloudstack.api.APICommand; @@ -334,7 +335,7 @@ public class CreatePortForwardingRuleCmd extends BaseAsyncCreateCmd implements P Ip privateIp = getVmSecondaryIp(); if (privateIp != null) { - if (!privateIp.isIp4()) { + if (!NetUtils.isValidIp(privateIp.toString())) { throw new InvalidParameterValueException("Invalid vm ip address"); } }