etan39
/
cloudstack
mirror of https://github.com/apache/cloudstack.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Apply suggestions from code review 

Co-authored-by: Fabricio Duarte <fabricio.duarte.jr@gmail.com>
This commit is contained in:
Gabriel Pordeus Santos 2025-03-03 17:04:25 -03:00 committed by Gabriel P. Santos
parent a8be0aaaa3
commit 380f6b2a6a
4 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
api/src/main/java/org/apache/cloudstack/api/response/IPAddressResponse.java
View File

@ -144,7 +144,7 @@ public class IPAddressResponse extends BaseResponseWithAnnotations implements Co
private String purpose;
@SerializedName(ApiConstants.VPC_ACCESS)
@Param(description = "Whether the calling account has access to this network's VPC", since = "4.20")
@Param(description = "Whether the calling account has access to this network's VPC", since = "4.21.0")
private boolean vpcAccess;
@SerializedName(ApiConstants.VPC_ID)

2
api/src/main/java/org/apache/cloudstack/api/response/NetworkResponse.java
View File

@ -204,7 +204,7 @@ public class NetworkResponse extends BaseResponseWithAssociatedNetwork implement
private Boolean specifyIpRanges;
@SerializedName(ApiConstants.VPC_ACCESS)
@Param(description = "Whether the calling account has access to this network's VPC", since = "4.20")
@Param(description = "Whether the calling account has access to this network's VPC", since = "4.21.0")
private Boolean vpcAccess;
@SerializedName(ApiConstants.VPC_ID)

2
server/src/main/java/com/cloud/api/ApiResponseHelper.java
View File

@ -1256,7 +1256,7 @@ public class ApiResponseHelper implements ResponseGenerator, ResourceIdSupport {
vpcAccessSetter.accept(true);
} catch (PermissionDeniedException e) {
vpcAccessSetter.accept(false);
logger.debug("Setting [%s] as false because the caller does not have access to the VPC [%s].", ApiConstants.VPC_ACCESS, vpc);
logger.debug("Setting [{}] as false because the caller does not have access to the VPC [{}].", ApiConstants.VPC_ACCESS, vpc);
}
vpcNameSetter.accept(vpc.getName());
vpcUuidSetter.accept(vpc.getUuid());

4
ui/src/views/network/VpcTiersTab.vue
View File

@ -783,9 +783,9 @@ export default {
this.showCreateNetworkModal = false
var params = {
vpcid: this.resource.id,
domainid: this.owner?.domainid ? this.owner.domainid : this.resource.domainid,
domainid: this.owner?.domainid || this.resource.domainid,
account: this.owner?.projectid ? null : (this.owner?.account ? this.owner.account : this.resource.account),
projectid: this.owner?.projectid ? this.owner.projectid : null,
projectid: this.owner?.projectid || null,
networkOfferingId: values.networkOffering,
name: values.name,
displayText: values.name,