etan39
/
cloudstack
mirror of https://github.com/apache/cloudstack.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

kvm: Add better logging when fetching a volume from libvirt 

Clearly show if a volume is found and if not, that the pool is being refreshed
and the fetch is tried again.

Due to my commit b53a9dcc9f the chance of a volume
not being found is slightly bigger, but the performance gain is enormous on larger
deployments.

This is why we clearly have to log that we are refreshing the pool information
when a volume is not found.

It could be that a volume is created on host A and a few seconds later host B tries
to access the volume. In that case host B's libvirt doesn't know about the volume
yet and has to refresh the pool before it does.

(cherry picked from commit 4ee82f1f40)
This commit is contained in:
Wido den Hollander 2014-10-10 00:57:21 +02:00 committed by David Nalley
parent da73d735b2
commit 3b65a5928b
1 changed files with 12 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/storage/LibvirtStorageAdaptor.java
View File

@ -94,21 +94,30 @@ public class LibvirtStorageAdaptor implements StorageAdaptor {
try {
vol = pool.storageVolLookupByName(volName);
} catch (LibvirtException e) {
s_logger.debug("Can't find volume: " + e.toString());
s_logger.debug("Could not find volume " + volName + ": " + e.getMessage());
}
/**
* The volume was not found in the storage pool
* This can happen when a volume has just been created on a different host and
* since then the libvirt storage pool has not been refreshed.
*/
if (vol == null) {
try {
s_logger.debug("Refreshing storage pool " + pool.getName());
refreshPool(pool);
} catch (LibvirtException e) {
s_logger.debug("failed to refresh pool: " + e.toString());
s_logger.debug("Failed to refresh storage pool: " + e.getMessage());
}
try {
vol = pool.storageVolLookupByName(volName);
s_logger.debug("Found volume " + volName + " in storage pool " + pool.getName() + " after refreshing the pool");
} catch (LibvirtException e) {
throw new CloudRuntimeException(e.toString());
throw new CloudRuntimeException("Could not find volume " + volName + ": " + e.getMessage());
}
}
return vol;
}