From 3c2bf12a930b19e3a8ea4cf9f2e130d7436883c2 Mon Sep 17 00:00:00 2001 From: Pearl Dsilva Date: Thu, 22 Feb 2024 11:40:30 -0500 Subject: [PATCH] NSX: Cleanup PF rule associated to an expunged VM --- .../main/java/org/apache/cloudstack/service/NsxElement.java | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/plugins/network-elements/nsx/src/main/java/org/apache/cloudstack/service/NsxElement.java b/plugins/network-elements/nsx/src/main/java/org/apache/cloudstack/service/NsxElement.java index 571e68496d6..40e4a5d2e44 100644 --- a/plugins/network-elements/nsx/src/main/java/org/apache/cloudstack/service/NsxElement.java +++ b/plugins/network-elements/nsx/src/main/java/org/apache/cloudstack/service/NsxElement.java @@ -509,8 +509,7 @@ public class NsxElement extends AdapterBase implements DhcpServiceProvider, Dns for (PortForwardingRule rule : rules) { IPAddressVO publicIp = ApiDBUtils.findIpAddressById(rule.getSourceIpAddressId()); UserVm vm = ApiDBUtils.findUserVmById(rule.getVirtualMachineId()); - if ((vm == null && (rule.getState() != FirewallRule.State.Revoke)) || - (vm != null && networkModel.getNicInNetwork(vm.getId(), network.getId()) == null)) { + if (vm == null && rule.getState() != FirewallRule.State.Revoke) { continue; } NsxOpObject nsxObject = getNsxOpObject(network);