etan39
/
cloudstack
mirror of https://github.com/apache/cloudstack.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

CLOUDSTACK-7195: log wide exceptions in security_group.py 

Some try/except in security_group.py catch a lot of exceptions. There
was already one fixed in CLOUDSTACK-1052. Here is another one. We use
logging.exception() to log those exceptions.

Signed-off-by: Vincent Bernat <Vincent.Bernat@exoscale.ch>
Signed-off-by: Pierre-Luc Dion <pdion891@apache.org>
This commit is contained in:
Vincent Bernat 2014-07-28 20:17:39 +02:00 committed by Pierre-Luc Dion
parent b3416f4a5e
commit 3ea8a1187a
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
scripts/vm/network/security_group.py
View File

@ -25,7 +25,6 @@ import os
import xml.dom.minidom
from optparse import OptionParser, OptionGroup, OptParseError, BadOptionError, OptionError, OptionConflictError, OptionValueError
import re
import traceback
import libvirt
logpath = "/var/run/cloud/" # FIXME: Logs should reside in /var/log/cloud
@ -678,7 +677,7 @@ def get_rule_logs_for_vms():
log = get_rule_log_for_vm(name)
result.append(log)
except:
logging.debug("Failed to get rule logs, better luck next time!")
logging.exception("Failed to get rule logs, better luck next time!")
print ";".join(result)
@ -883,8 +882,7 @@ def add_network_rules(vm_name, vm_id, vm_ip, signature, seqno, vmMac, rules, vif
return 'true'
except:
exceptionText = traceback.format_exc()
logging.debug("Failed to network rule !: " + exceptionText)
logging.exception("Failed to network rule !")
def getVifs(vmName):
vifs = []