From 3f80cd3c66ad0f01745b9dad74b29034e789e674 Mon Sep 17 00:00:00 2001
From: Abhishek Kumar <abhishek.mrt22@gmail.com>
Date: Tue, 27 Aug 2024 13:06:25 +0530
Subject: [PATCH] optimize db list.size() cases

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
---
 .../main/java/com/cloud/dc/dao/DataCenterIpAddressDaoImpl.java | 3 +--
 .../src/main/java/com/cloud/dc/dao/DataCenterVnetDaoImpl.java  | 2 +-
 .../src/main/java/com/cloud/network/dao/IPAddressDaoImpl.java  | 2 +-
 .../src/main/java/com/cloud/network/dao/NetworkDaoImpl.java    | 3 +--
 .../main/java/com/cloud/secstorage/CommandExecLogDaoImpl.java  | 3 +--
 .../src/main/java/com/cloud/vm/dao/NicIpAliasDaoImpl.java      | 3 +--
 6 files changed, 6 insertions(+), 10 deletions(-)

diff --git a/engine/schema/src/main/java/com/cloud/dc/dao/DataCenterIpAddressDaoImpl.java b/engine/schema/src/main/java/com/cloud/dc/dao/DataCenterIpAddressDaoImpl.java
index e58b08da4c1..ded9d0b67dc 100644
--- a/engine/schema/src/main/java/com/cloud/dc/dao/DataCenterIpAddressDaoImpl.java
+++ b/engine/schema/src/main/java/com/cloud/dc/dao/DataCenterIpAddressDaoImpl.java
@@ -296,8 +296,7 @@ public class DataCenterIpAddressDaoImpl extends GenericDaoBase<DataCenterIpAddre
         sc.addAnd("podId", SearchCriteria.Op.EQ, podId);
         sc.addAnd("dataCenterId", SearchCriteria.Op.EQ, dcId);
 
-        List<DataCenterIpAddressVO> result = listBy(sc);
-        return result.size();
+        return getCount(sc);
     }
 
     public DataCenterIpAddressDaoImpl() {
diff --git a/engine/schema/src/main/java/com/cloud/dc/dao/DataCenterVnetDaoImpl.java b/engine/schema/src/main/java/com/cloud/dc/dao/DataCenterVnetDaoImpl.java
index 1c29e6a944c..ff668249779 100644
--- a/engine/schema/src/main/java/com/cloud/dc/dao/DataCenterVnetDaoImpl.java
+++ b/engine/schema/src/main/java/com/cloud/dc/dao/DataCenterVnetDaoImpl.java
@@ -81,7 +81,7 @@ public class DataCenterVnetDaoImpl extends GenericDaoBase<DataCenterVnetVO, Long
     public int countAllocatedVnets(long physicalNetworkId) {
         SearchCriteria<DataCenterVnetVO> sc = DcSearchAllocated.create();
         sc.setParameters("physicalNetworkId", physicalNetworkId);
-        return listBy(sc).size();
+        return getCount(sc);
     }
 
     @Override
diff --git a/engine/schema/src/main/java/com/cloud/network/dao/IPAddressDaoImpl.java b/engine/schema/src/main/java/com/cloud/network/dao/IPAddressDaoImpl.java
index 412e87ea956..82956a57397 100644
--- a/engine/schema/src/main/java/com/cloud/network/dao/IPAddressDaoImpl.java
+++ b/engine/schema/src/main/java/com/cloud/network/dao/IPAddressDaoImpl.java
@@ -418,7 +418,7 @@ public class IPAddressDaoImpl extends GenericDaoBase<IPAddressVO, Long> implemen
     public long countFreeIpsInVlan(long vlanDbId) {
         SearchCriteria<IPAddressVO> sc = VlanDbIdSearchUnallocated.create();
         sc.setParameters("vlanDbId", vlanDbId);
-        return listBy(sc).size();
+        return getCount(sc);
     }
 
     @Override
diff --git a/engine/schema/src/main/java/com/cloud/network/dao/NetworkDaoImpl.java b/engine/schema/src/main/java/com/cloud/network/dao/NetworkDaoImpl.java
index fa448b026e4..0aae532eac5 100644
--- a/engine/schema/src/main/java/com/cloud/network/dao/NetworkDaoImpl.java
+++ b/engine/schema/src/main/java/com/cloud/network/dao/NetworkDaoImpl.java
@@ -415,8 +415,7 @@ public class NetworkDaoImpl extends GenericDaoBase<NetworkVO, Long>implements Ne
         sc.setParameters("broadcastUri", broadcastURI);
         sc.setParameters("guestType", guestTypes);
         sc.setJoinParameters("persistent", "persistent", isPersistent);
-        List<NetworkVO> persistentNetworks = search(sc, null);
-        return persistentNetworks.size();
+        return getCount(sc);
     }
 
     @Override
diff --git a/engine/schema/src/main/java/com/cloud/secstorage/CommandExecLogDaoImpl.java b/engine/schema/src/main/java/com/cloud/secstorage/CommandExecLogDaoImpl.java
index a37acdf6029..8229c3a62fc 100644
--- a/engine/schema/src/main/java/com/cloud/secstorage/CommandExecLogDaoImpl.java
+++ b/engine/schema/src/main/java/com/cloud/secstorage/CommandExecLogDaoImpl.java
@@ -55,8 +55,7 @@ public class CommandExecLogDaoImpl extends GenericDaoBase<CommandExecLogVO, Long
         SearchCriteria<CommandExecLogVO> sc = CommandSearch.create();
         sc.setParameters("host_id", id);
         sc.setParameters("command_name", "CopyCommand");
-        List<CommandExecLogVO> copyCmds = customSearch(sc, null);
-        return copyCmds.size();
+        return getCount(sc);
     }
 
     @Override
diff --git a/engine/schema/src/main/java/com/cloud/vm/dao/NicIpAliasDaoImpl.java b/engine/schema/src/main/java/com/cloud/vm/dao/NicIpAliasDaoImpl.java
index 887b3d73087..44866c0a358 100644
--- a/engine/schema/src/main/java/com/cloud/vm/dao/NicIpAliasDaoImpl.java
+++ b/engine/schema/src/main/java/com/cloud/vm/dao/NicIpAliasDaoImpl.java
@@ -170,8 +170,7 @@ public class NicIpAliasDaoImpl extends GenericDaoBase<NicIpAliasVO, Long> implem
     public Integer countAliasIps(long id) {
         SearchCriteria<NicIpAliasVO> sc = AllFieldsSearch.create();
         sc.setParameters("instanceId", id);
-        List<NicIpAliasVO> list = listBy(sc);
-        return list.size();
+        return getCount(sc);
     }
 
     @Override