diff --git a/core/src/com/cloud/agent/Listener.java b/core/src/com/cloud/agent/Listener.java index 6fbe0a2cf01..7f4ae8b3535 100755 --- a/core/src/com/cloud/agent/Listener.java +++ b/core/src/com/cloud/agent/Listener.java @@ -72,11 +72,12 @@ public interface Listener { * This method is called by AgentManager when an agent made a * connection to this server if the listener has * been registered for host events. - * @param agentId id of the agent * @param cmd command sent by the agent to the server on startup. + * @param forRebalance TODO + * @param agentId id of the agent * @throws ConnectionException if host has problems and needs to put into maintenance state. */ - void processConnect(HostVO host, StartupCommand cmd) throws ConnectionException; + void processConnect(HostVO host, StartupCommand cmd, boolean forRebalance) throws ConnectionException; /** * This method is called by AgentManager when an agent disconnects @@ -119,12 +120,5 @@ public interface Listener { * @return true if processed; false if not. */ boolean processTimeout(long agentId, long seq); - - - /** - * If set to false, processConnect wouldn't be called for the host - * - * @return true when connect has to be processed when host connects as a part of rebalance process, false otherwise - */ - boolean processConnectForRebalanceHost(); + } diff --git a/server/src/com/cloud/agent/manager/AgentManagerImpl.java b/server/src/com/cloud/agent/manager/AgentManagerImpl.java index e080081427a..68d17a711db 100755 --- a/server/src/com/cloud/agent/manager/AgentManagerImpl.java +++ b/server/src/com/cloud/agent/manager/AgentManagerImpl.java @@ -1097,16 +1097,12 @@ public class AgentManagerImpl implements AgentManager, HandlerFactory, Manager { long hostId = attache.getId(); HostVO host = _hostDao.findById(hostId); for (Pair monitor : _hostMonitors) { - //some listeneres don't have to be notified when host is connected as a part of rebalance process - boolean processConnect = (!forRebalance || (forRebalance && monitor.second().processConnectForRebalanceHost())); - if (s_logger.isDebugEnabled() && processConnect) { + if (s_logger.isDebugEnabled()) { s_logger.debug("Sending Connect to listener: " + monitor.second().getClass().getSimpleName()); } for (int i = 0; i < cmd.length; i++) { try { - if (processConnect) { - monitor.second().processConnect(host, cmd[i]); - } + monitor.second().processConnect(host, cmd[i], forRebalance); } catch (Exception e) { if (e instanceof ConnectionException) { ConnectionException ce = (ConnectionException)e; diff --git a/server/src/com/cloud/agent/manager/AgentMonitor.java b/server/src/com/cloud/agent/manager/AgentMonitor.java index eae3d545f0d..3e5a134735f 100755 --- a/server/src/com/cloud/agent/manager/AgentMonitor.java +++ b/server/src/com/cloud/agent/manager/AgentMonitor.java @@ -185,7 +185,7 @@ public class AgentMonitor extends Thread implements Listener { } @Override - public void processConnect(HostVO host, StartupCommand cmd) { + public void processConnect(HostVO host, StartupCommand cmd, boolean forRebalance) { s_logger.debug("Registering agent monitor for " + host.getId()); } @@ -204,8 +204,4 @@ public class AgentMonitor extends Thread implements Listener { return -1; } - @Override - public boolean processConnectForRebalanceHost() { - return true; - } } diff --git a/server/src/com/cloud/agent/manager/SynchronousListener.java b/server/src/com/cloud/agent/manager/SynchronousListener.java index 89d4a758a01..de501be5c22 100755 --- a/server/src/com/cloud/agent/manager/SynchronousListener.java +++ b/server/src/com/cloud/agent/manager/SynchronousListener.java @@ -80,7 +80,7 @@ public class SynchronousListener implements Listener { } @Override - public void processConnect(HostVO agent, StartupCommand cmd) { + public void processConnect(HostVO agent, StartupCommand cmd, boolean forRebalance) { } @Override @@ -132,8 +132,4 @@ public class SynchronousListener implements Listener { return -1; } - @Override - public boolean processConnectForRebalanceHost() { - return true; - } } diff --git a/server/src/com/cloud/capacity/CapacityManagerImpl.java b/server/src/com/cloud/capacity/CapacityManagerImpl.java index 0d86e8c8398..25e55a321fd 100644 --- a/server/src/com/cloud/capacity/CapacityManagerImpl.java +++ b/server/src/com/cloud/capacity/CapacityManagerImpl.java @@ -653,7 +653,7 @@ public class CapacityManagerImpl implements CapacityManager, StateListener