From 4bdcddf96c9f249f93019c0fe0c8022389df7e6a Mon Sep 17 00:00:00 2001 From: Murali Reddy Date: Thu, 17 Nov 2011 17:22:14 -0800 Subject: [PATCH] fixed bug in addSrxFirewallCmd API --- .../network/element/JuniperSRXExternalFirewallElement.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/server/src/com/cloud/network/element/JuniperSRXExternalFirewallElement.java b/server/src/com/cloud/network/element/JuniperSRXExternalFirewallElement.java index 904216cb3b9..b7a990b70c8 100644 --- a/server/src/com/cloud/network/element/JuniperSRXExternalFirewallElement.java +++ b/server/src/com/cloud/network/element/JuniperSRXExternalFirewallElement.java @@ -378,7 +378,7 @@ public class JuniperSRXExternalFirewallElement extends ExternalFirewallDeviceMan @Override public ExternalFirewallDeviceVO addSrxFirewall(AddSrxFirewallCmd cmd) { String deviceName = cmd.getDeviceType(); - if (deviceName.equalsIgnoreCase(NetworkDevice.JuniperSRXFirewall.getName())) { + if (!deviceName.equalsIgnoreCase(NetworkDevice.JuniperSRXFirewall.getName())) { throw new InvalidParameterValueException("Invalid SRX firewall device type"); } return addExternalFirewall(cmd.getPhysicalNetworkId(), cmd.getUrl(), cmd.getUsername(), cmd.getPassword(), deviceName,