From 4c89cc57ae051773140b84a38b4ee35ecca9a825 Mon Sep 17 00:00:00 2001
From: prachi <prachi@cloud.com>
Date: Fri, 6 May 2011 14:39:25 -0700
Subject: [PATCH] Bug 9652: Need to provide a way to specify deployment plan
 during VM start

Changes:
- Throw an exception if the deployment plan passed into start() cannot be satisfied by the current constraints (such as root volume is already created in a pool in a different
cluster).
---
 .../cloud/vm/VirtualMachineManagerImpl.java   | 25 ++++++++++++++++---
 1 file changed, 21 insertions(+), 4 deletions(-)

diff --git a/server/src/com/cloud/vm/VirtualMachineManagerImpl.java b/server/src/com/cloud/vm/VirtualMachineManagerImpl.java
index e05c3ad3ee8..0d059c02559 100755
--- a/server/src/com/cloud/vm/VirtualMachineManagerImpl.java
+++ b/server/src/com/cloud/vm/VirtualMachineManagerImpl.java
@@ -608,13 +608,30 @@ public class VirtualMachineManagerImpl implements VirtualMachineManager, Listene
 
                 StoragePoolVO pool = _storagePoolDao.findById(vol.getPoolId());
                 if (!pool.isInMaintenance()) {
+                    if (s_logger.isDebugEnabled()) {
+                        s_logger.debug("Root volume is ready, need to place VM in volume's cluster");
+                    }
                     long rootVolDcId = pool.getDataCenterId();
                     Long rootVolPodId = pool.getPodId();
                     Long rootVolClusterId = pool.getClusterId();
-                    plan = new DataCenterDeployment(rootVolDcId, rootVolPodId, rootVolClusterId, null, vol.getPoolId());
-                    if (s_logger.isDebugEnabled()) {
-                        s_logger.debug(vol + " is READY, changing deployment plan to use this pool's dcId: " + rootVolDcId + " , podId: " + rootVolPodId + " , and clusterId: " + rootVolClusterId);
-                    }
+                    if(planToDeploy != null){
+                        Long clusterIdSpecified = planToDeploy.getClusterId();
+                        if(clusterIdSpecified != null && rootVolClusterId != null){
+                            if(rootVolClusterId.longValue() != clusterIdSpecified.longValue()){
+                                //cannot satisfy the plan passed in to the planner
+                                if (s_logger.isDebugEnabled()) {
+                                    s_logger.debug("Cannot satisfy the deployment plan passed in since the ready Root volume is in different cluster. volume's cluster: "+rootVolClusterId + ", cluster specified: "+clusterIdSpecified);
+                                }
+                                throw new ResourceUnavailableException("Root volume is ready in different cluster, Deployment plan provided cannot be satisfied, unable to create a deployment for " + vm, Cluster.class, clusterIdSpecified);
+                            }
+                        }
+                        plan = new DataCenterDeployment(planToDeploy.getDataCenterId(), planToDeploy.getPodId(), planToDeploy.getClusterId(), planToDeploy.getHostId(), vol.getPoolId());
+                    }else{
+                        plan = new DataCenterDeployment(rootVolDcId, rootVolPodId, rootVolClusterId, null, vol.getPoolId());
+                        if (s_logger.isDebugEnabled()) {
+                            s_logger.debug(vol + " is READY, changing deployment plan to use this pool's dcId: " + rootVolDcId + " , podId: " + rootVolPodId + " , and clusterId: " + rootVolClusterId);
+                        }
+                    }                    
                 }
             }