From 4e07dd1dc4b4618fff2ef25c846ce6b95a8e580d Mon Sep 17 00:00:00 2001 From: Koushik Das Date: Thu, 18 Sep 2014 17:10:25 +0530 Subject: [PATCH] CLOUDSTACK-7581: Empty 'ID' parameters allowed in API calls Fix is to fail API calls with empty 'id' parameter value upfront rather than going ahead and failing with NPE later on --- server/src/com/cloud/api/dispatch/ParamProcessWorker.java | 2 -- 1 file changed, 2 deletions(-) diff --git a/server/src/com/cloud/api/dispatch/ParamProcessWorker.java b/server/src/com/cloud/api/dispatch/ParamProcessWorker.java index 9a98f3346c5..ff6d666a8fe 100644 --- a/server/src/com/cloud/api/dispatch/ParamProcessWorker.java +++ b/server/src/com/cloud/api/dispatch/ParamProcessWorker.java @@ -329,8 +329,6 @@ public class ParamProcessWorker implements DispatchWorker { field.set(cmdObj, listParam); break; case UUID: - if (paramObj.toString().isEmpty()) - break; final Long internalId = translateUuidToInternalId(paramObj.toString(), annotation); field.set(cmdObj, internalId); break;