From 4f749378551b3035ff0617f6f8df1fe3618b9c27 Mon Sep 17 00:00:00 2001 From: Suresh Kumar Anaparti Date: Fri, 2 Jan 2026 14:04:59 +0530 Subject: [PATCH] Event typo fix (#12350) --- .../ObjectInDataStoreStateMachine.java | 6 +-- .../manager/StorageCacheManagerImpl.java | 2 +- .../motion/AncientDataMotionStrategy.java | 4 +- .../StorageSystemDataMotionStrategy.java | 12 ++--- .../image/SecondaryStorageServiceImpl.java | 4 +- .../storage/image/TemplateServiceImpl.java | 14 +++--- .../snapshot/DefaultSnapshotStrategy.java | 2 +- .../storage/snapshot/SnapshotServiceImpl.java | 12 ++--- .../datastore/DataObjectManagerImpl.java | 8 ++-- .../ObjectInDataStoreManagerImpl.java | 16 +++---- .../storage/volume/VolumeObject.java | 2 +- .../storage/volume/VolumeServiceImpl.java | 48 +++++++++---------- .../storage/volume/VolumeObjectTest.java | 4 +- .../motion/StorPoolDataMotionStrategy.java | 4 +- .../snapshot/StorPoolSnapshotStrategy.java | 2 +- 15 files changed, 68 insertions(+), 72 deletions(-) diff --git a/engine/api/src/main/java/org/apache/cloudstack/engine/subsystem/api/storage/ObjectInDataStoreStateMachine.java b/engine/api/src/main/java/org/apache/cloudstack/engine/subsystem/api/storage/ObjectInDataStoreStateMachine.java index a8e80313768..d4ca163e4e6 100644 --- a/engine/api/src/main/java/org/apache/cloudstack/engine/subsystem/api/storage/ObjectInDataStoreStateMachine.java +++ b/engine/api/src/main/java/org/apache/cloudstack/engine/subsystem/api/storage/ObjectInDataStoreStateMachine.java @@ -33,9 +33,9 @@ public interface ObjectInDataStoreStateMachine extends StateObject entry : volumeToPool.entrySet()) { VolumeInfo volume = entry.getKey(); snapshotMgr.cleanupSnapshotsByVolume(volume.getId()); - volume.processEvent(Event.OperationSuccessed); + volume.processEvent(Event.OperationSucceeded); } future.complete(res); } @@ -2431,7 +2431,7 @@ public class VolumeServiceImpl implements VolumeService { } } else { - vo.processEvent(Event.OperationSuccessed, result.getAnswer()); + vo.processEvent(Event.OperationSucceeded, result.getAnswer()); if (vo.getSize() != null) { // publish usage events @@ -2551,7 +2551,7 @@ public class VolumeServiceImpl implements VolumeService { } try { - volume.processEvent(Event.OperationSuccessed); + volume.processEvent(Event.OperationSucceeded); } catch (Exception e) { logger.debug("Failed to change volume state (after resize success)", e); } @@ -2640,7 +2640,7 @@ public class VolumeServiceImpl implements VolumeService { if (volume.getState() == State.NotUploaded || volume.getState() == State.UploadInProgress) { VolumeObject volObj = (VolumeObject)volFactory.getVolume(volume.getId()); - volObj.processEvent(Event.OperationSuccessed); + volObj.processEvent(Event.OperationSucceeded); } if (volInfo.getSize() > 0) { diff --git a/engine/storage/volume/src/test/java/org/apache/cloudstack/storage/volume/VolumeObjectTest.java b/engine/storage/volume/src/test/java/org/apache/cloudstack/storage/volume/VolumeObjectTest.java index 58f47a5db64..5701bc49e15 100644 --- a/engine/storage/volume/src/test/java/org/apache/cloudstack/storage/volume/VolumeObjectTest.java +++ b/engine/storage/volume/src/test/java/org/apache/cloudstack/storage/volume/VolumeObjectTest.java @@ -147,7 +147,7 @@ public class VolumeObjectTest extends TestCase{ expectedResult.put(ObjectInDataStoreStateMachine.Event.MigrationRequested, Volume.Event.CopyRequested); expectedResult.put(ObjectInDataStoreStateMachine.Event.DestroyRequested, Volume.Event.DestroyRequested); expectedResult.put(ObjectInDataStoreStateMachine.Event.ExpungeRequested, Volume.Event.ExpungingRequested); - expectedResult.put(ObjectInDataStoreStateMachine.Event.OperationSuccessed, Volume.Event.OperationSucceeded); + expectedResult.put(ObjectInDataStoreStateMachine.Event.OperationSucceeded, Volume.Event.OperationSucceeded); expectedResult.put(ObjectInDataStoreStateMachine.Event.MigrationCopySucceeded, Volume.Event.MigrationCopySucceeded); expectedResult.put(ObjectInDataStoreStateMachine.Event.OperationFailed, Volume.Event.OperationFailed); expectedResult.put(ObjectInDataStoreStateMachine.Event.MigrationCopyFailed, Volume.Event.MigrationCopyFailed); @@ -168,7 +168,7 @@ public class VolumeObjectTest extends TestCase{ expectedResult.put(ObjectInDataStoreStateMachine.Event.MigrationCopyRequested, Volume.Event.MigrationCopyRequested); expectedResult.put(ObjectInDataStoreStateMachine.Event.DestroyRequested, Volume.Event.DestroyRequested); expectedResult.put(ObjectInDataStoreStateMachine.Event.ExpungeRequested, Volume.Event.ExpungingRequested); - expectedResult.put(ObjectInDataStoreStateMachine.Event.OperationSuccessed, Volume.Event.OperationSucceeded); + expectedResult.put(ObjectInDataStoreStateMachine.Event.OperationSucceeded, Volume.Event.OperationSucceeded); expectedResult.put(ObjectInDataStoreStateMachine.Event.MigrationCopySucceeded, Volume.Event.MigrationCopySucceeded); expectedResult.put(ObjectInDataStoreStateMachine.Event.OperationFailed, Volume.Event.OperationFailed); expectedResult.put(ObjectInDataStoreStateMachine.Event.MigrationCopyFailed, Volume.Event.MigrationCopyFailed); diff --git a/plugins/storage/volume/storpool/src/main/java/org/apache/cloudstack/storage/motion/StorPoolDataMotionStrategy.java b/plugins/storage/volume/storpool/src/main/java/org/apache/cloudstack/storage/motion/StorPoolDataMotionStrategy.java index aa972d44343..5a4802ab264 100644 --- a/plugins/storage/volume/storpool/src/main/java/org/apache/cloudstack/storage/motion/StorPoolDataMotionStrategy.java +++ b/plugins/storage/volume/storpool/src/main/java/org/apache/cloudstack/storage/motion/StorPoolDataMotionStrategy.java @@ -453,8 +453,8 @@ public class StorPoolDataMotionStrategy implements DataMotionStrategy { VolumeInfo destVolumeInfo = entry.getValue(); if (success) { - srcVolumeInfo.processEvent(Event.OperationSuccessed); - destVolumeInfo.processEvent(Event.OperationSuccessed); + srcVolumeInfo.processEvent(Event.OperationSucceeded); + destVolumeInfo.processEvent(Event.OperationSucceeded); _volumeDao.updateUuid(srcVolumeInfo.getId(), destVolumeInfo.getId()); diff --git a/plugins/storage/volume/storpool/src/main/java/org/apache/cloudstack/storage/snapshot/StorPoolSnapshotStrategy.java b/plugins/storage/volume/storpool/src/main/java/org/apache/cloudstack/storage/snapshot/StorPoolSnapshotStrategy.java index 5ec86df91e1..8a51e2672ea 100644 --- a/plugins/storage/volume/storpool/src/main/java/org/apache/cloudstack/storage/snapshot/StorPoolSnapshotStrategy.java +++ b/plugins/storage/volume/storpool/src/main/java/org/apache/cloudstack/storage/snapshot/StorPoolSnapshotStrategy.java @@ -201,7 +201,7 @@ public class StorPoolSnapshotStrategy implements SnapshotStrategy { if (parent.getPath() != null && parent.getPath().equalsIgnoreCase(snapshot.getPath())) { logger.debug("for empty delta snapshot, only mark it as destroyed in db"); snapshot.processEvent(Event.DestroyRequested); - snapshot.processEvent(Event.OperationSuccessed); + snapshot.processEvent(Event.OperationSucceeded); deleted = true; if (!resultIsSet) { result = true;