From 51f2ce0e8645dfc588c6f2e81fa82e17c7158afb Mon Sep 17 00:00:00 2001 From: Kris McQueen Date: Fri, 22 Oct 2010 18:05:53 -0700 Subject: [PATCH] bug 6690: if the exception is one that we are handling (reporting information about bad API parameters, for example) don't log the exception. If we aren't handling it, *then* we should log the exception. status 6690: resolved fixed --- server/src/com/cloud/api/ApiDispatcher.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/server/src/com/cloud/api/ApiDispatcher.java b/server/src/com/cloud/api/ApiDispatcher.java index 326191b9b3a..12e45a8df8a 100644 --- a/server/src/com/cloud/api/ApiDispatcher.java +++ b/server/src/com/cloud/api/ApiDispatcher.java @@ -224,12 +224,12 @@ public class ApiDispatcher { if (cause instanceof AsyncCommandQueued) { throw (AsyncCommandQueued)cause; } - s_logger.warn("Exception executing method " + methodName + " for command " + cmd.getClass().getSimpleName(), ite); if (cause instanceof InvalidParameterValueException) { throw new ServerApiException(BaseCmd.PARAM_ERROR, cause.getMessage()); } else if (cause instanceof PermissionDeniedException) { throw new ServerApiException(BaseCmd.ACCOUNT_ERROR, cause.getMessage()); } + s_logger.warn("Exception executing method " + methodName + " for command " + cmd.getClass().getSimpleName(), ite); throw new ServerApiException(BaseCmd.INTERNAL_ERROR, "Unable to execute method " + methodName + " for command " + cmd.getClass().getSimpleName() + ", internal error in the implementation."); } catch (IllegalAccessException iae) { s_logger.warn("Exception executing method " + methodName + " for command " + cmd.getClass().getSimpleName(), iae);