From 540d9572fd491db3ce182d26636fc74ada4e171c Mon Sep 17 00:00:00 2001 From: Rohit Yadav Date: Fri, 13 May 2016 08:54:24 +0530 Subject: [PATCH] CLOUDSTACK-9348: Make NioConnectio loop less aggressive - Reverts ea2286 that introduced a wakeup on each connection loop run. - In SSL handshake code removes delegated tasks to be run in separate threads. Signed-off-by: Rohit Yadav --- utils/src/main/java/com/cloud/utils/nio/Link.java | 5 ++++- utils/src/main/java/com/cloud/utils/nio/NioConnection.java | 2 -- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/utils/src/main/java/com/cloud/utils/nio/Link.java b/utils/src/main/java/com/cloud/utils/nio/Link.java index da2c0d54e87..02ffaab4e02 100644 --- a/utils/src/main/java/com/cloud/utils/nio/Link.java +++ b/utils/src/main/java/com/cloud/utils/nio/Link.java @@ -615,7 +615,10 @@ public class Link { case NEED_TASK: Runnable task; while ((task = sslEngine.getDelegatedTask()) != null) { - new Thread(task).run(); + if (s_logger.isTraceEnabled()) { + s_logger.trace("SSL: Running delegated task!"); + } + task.run(); } break; case FINISHED: diff --git a/utils/src/main/java/com/cloud/utils/nio/NioConnection.java b/utils/src/main/java/com/cloud/utils/nio/NioConnection.java index 749e552c2c7..6fdb4736ac7 100644 --- a/utils/src/main/java/com/cloud/utils/nio/NioConnection.java +++ b/utils/src/main/java/com/cloud/utils/nio/NioConnection.java @@ -171,8 +171,6 @@ public abstract class NioConnection implements Callable { } catch (final IOException e) { s_logger.error("Agent will die due to this IOException!", e); throw new NioConnectionException(e.getMessage(), e); - } finally { - _selector.wakeup(); } } _isStartup = false;