From d9319e645c7522c3bd76bed7117dc98ecd530f9b Mon Sep 17 00:00:00 2001 From: Wei Zhou Date: Thu, 10 Aug 2023 22:28:49 +0800 Subject: [PATCH 1/2] storpool: fix pom.xml which caused docker image build failures (#7845) steps to reproduce the issue: - git clone https://github.com/apache/cloudstack.git - cd cloudstack - rm -rf .git/ - run `mvn -P developer,systemvm clean install` Without this PR, it fails with error ``` > [ 8/10] RUN mvn -Pdeveloper -Dsimulator -DskipTests clean install: 668.1 [ERROR] Failed to execute goal pl.project13.maven:git-commit-id-plugin:4.9.10:revision (get-the-git-infos) on project cloud-plugin-storage-volume-storpool: .git directory is not found! Please specify a valid [dotGitDirectory] in your pom.xml -> [Help 1] ``` --- plugins/storage/volume/storpool/pom.xml | 26 +++++++++++++++++++++++++ 1 file changed, 26 insertions(+) diff --git a/plugins/storage/volume/storpool/pom.xml b/plugins/storage/volume/storpool/pom.xml index ee4c5cfb6f0..058f3e678ed 100644 --- a/plugins/storage/volume/storpool/pom.xml +++ b/plugins/storage/volume/storpool/pom.xml @@ -69,6 +69,31 @@ + + org.codehaus.gmaven + gmaven-plugin + 1.5 + + + set-properties + validate + + execute + + + 1.7 + + File git = new File("./.git") + if (!git.exists()) { + pom.properties['storpool.skip.git.properties'] = 'true' + } else { + pom.properties['storpool.skip.git.properties'] = 'false' + } + + + + + maven-surefire-plugin @@ -96,6 +121,7 @@ + ${storpool.skip.git.properties} ${project.basedir}/.git git false From 29c7b3167eb62d7290a9e7ac51d1dada878620a4 Mon Sep 17 00:00:00 2001 From: Rohit Yadav Date: Fri, 11 Aug 2023 11:08:47 +0530 Subject: [PATCH 2/2] cloudstack: bump to use 4.18.1.0 systemvmtemplate (#7828) * cloudstack: bump to use 4.18.1.0 systemvmtemplate Use new 4.18.1.0 systemvmtemplate Signed-off-by: Rohit Yadav * fix cd ISO url Signed-off-by: Rohit Yadav --------- Signed-off-by: Rohit Yadav --- pom.xml | 2 +- .../systemvmtemplate/scripts/configure_systemvm_services.sh | 2 +- tools/appliance/systemvmtemplate/template.json | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/pom.xml b/pom.xml index f9be3ab98a2..bdddcd5be6c 100644 --- a/pom.xml +++ b/pom.xml @@ -50,7 +50,7 @@ UTF-8 UTF-8 https://download.cloudstack.org/systemvm - 4.18.0.0 + 4.18.1.0 apache https://sonarcloud.io diff --git a/tools/appliance/systemvmtemplate/scripts/configure_systemvm_services.sh b/tools/appliance/systemvmtemplate/scripts/configure_systemvm_services.sh index d1cfb4661fc..f80d62f7a1e 100644 --- a/tools/appliance/systemvmtemplate/scripts/configure_systemvm_services.sh +++ b/tools/appliance/systemvmtemplate/scripts/configure_systemvm_services.sh @@ -19,7 +19,7 @@ set -e set -x -CLOUDSTACK_RELEASE=4.18.0 +CLOUDSTACK_RELEASE=4.18.1 function configure_apache2() { # Enable ssl, rewrite and auth diff --git a/tools/appliance/systemvmtemplate/template.json b/tools/appliance/systemvmtemplate/template.json index 21a74b83494..b9d36324dce 100644 --- a/tools/appliance/systemvmtemplate/template.json +++ b/tools/appliance/systemvmtemplate/template.json @@ -28,7 +28,7 @@ "headless": true, "http_directory": "http", "iso_checksum": "sha512:4460ef6470f6d8ae193c268e213d33a6a5a0da90c2d30c1024784faa4e4473f0c9b546a41e2d34c43fbbd43542ae4fb93cfd5cb6ac9b88a476f1a6877c478674", - "iso_url": "https://cdimage.debian.org/debian-cd/11.7.0/amd64/iso-cd/debian-11.7.0-amd64-netinst.iso", + "iso_url": "https://cdimage.debian.org/mirror/cdimage/archive/11.7.0/amd64/iso-cd/debian-11.7.0-amd64-netinst.iso", "net_device": "virtio-net", "output_directory": "../dist", "qemuargs": [