From 564013bec0d4356232d93ac52a3e44638578bff0 Mon Sep 17 00:00:00 2001 From: Laszlo Hornyak Date: Sat, 8 Jun 2013 21:39:52 +0200 Subject: [PATCH] String instantiation is not needed Removed a String instntiation, test case added Signed-off-by: Laszlo Hornyak --- utils/src/com/cloud/utils/net/NetUtils.java | 2 +- utils/test/com/cloud/utils/net/NetUtilsTest.java | 5 +++++ 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/utils/src/com/cloud/utils/net/NetUtils.java b/utils/src/com/cloud/utils/net/NetUtils.java index 5c13454da79..60993799b41 100755 --- a/utils/src/com/cloud/utils/net/NetUtils.java +++ b/utils/src/com/cloud/utils/net/NetUtils.java @@ -257,7 +257,7 @@ public class NetUtils { return ipFromInetAddress(addr); } - return new String("127.0.0.1"); + return "127.0.0.1"; } public static String ipFromInetAddress(InetAddress addr) { diff --git a/utils/test/com/cloud/utils/net/NetUtilsTest.java b/utils/test/com/cloud/utils/net/NetUtilsTest.java index 38fe21d5324..3cfc98fb3b6 100644 --- a/utils/test/com/cloud/utils/net/NetUtilsTest.java +++ b/utils/test/com/cloud/utils/net/NetUtilsTest.java @@ -168,4 +168,9 @@ public class NetUtilsTest extends TestCase { newMac = NetUtils.generateMacOnIncrease(mac, 16); assertTrue(newMac.equals("06:00:0f:00:45:67")); } + + @Test + public void testGetLocalIPString() { + assertNotNull(NetUtils.getLocalIPString()); + } }