From 57eb7948ca3608f6ed6d86de3ca21df8cacdf4ea Mon Sep 17 00:00:00 2001 From: Pearl Dsilva Date: Thu, 12 Feb 2026 12:47:48 -0500 Subject: [PATCH] fix issue with test --- .../org/apache/cloudstack/backup/BackupManagerTest.java | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/server/src/test/java/org/apache/cloudstack/backup/BackupManagerTest.java b/server/src/test/java/org/apache/cloudstack/backup/BackupManagerTest.java index cfac99e93ae..1e8c27f0f77 100644 --- a/server/src/test/java/org/apache/cloudstack/backup/BackupManagerTest.java +++ b/server/src/test/java/org/apache/cloudstack/backup/BackupManagerTest.java @@ -125,6 +125,8 @@ import static org.junit.Assert.assertNull; import static org.junit.Assert.assertTrue; import static org.junit.Assert.fail; import static org.mockito.ArgumentMatchers.any; +import static org.mockito.ArgumentMatchers.anyLong; +import static org.mockito.ArgumentMatchers.anyString; import static org.mockito.Mockito.doNothing; import static org.mockito.Mockito.doReturn; import static org.mockito.Mockito.mock; @@ -2525,6 +2527,7 @@ public class BackupManagerTest { Long sourceOfferingId = 1L; Long zoneId = 10L; Long savedOfferingId = 2L; + String externalId = UUID.randomUUID().toString(); List providedDomainIds = List.of(11L); // command @@ -2534,12 +2537,13 @@ public class BackupManagerTest { when(cmd.getDescription()).thenReturn(null); when(cmd.getExternalId()).thenReturn(null); when(cmd.getUserDrivenBackups()).thenReturn(null); + when(cmd.getZoneId()).thenReturn(null); when(cmd.getDomainIds()).thenReturn(providedDomainIds); // source offering BackupOfferingVO sourceOffering = Mockito.mock(BackupOfferingVO.class); when(sourceOffering.getZoneId()).thenReturn(zoneId); - when(sourceOffering.getExternalId()).thenReturn("ext-src"); + when(sourceOffering.getExternalId()).thenReturn(externalId); when(sourceOffering.getProvider()).thenReturn("testbackupprovider"); when(sourceOffering.getDescription()).thenReturn("src desc"); when(sourceOffering.isUserDrivenBackupAllowed()).thenReturn(true); @@ -2581,6 +2585,7 @@ public class BackupManagerTest { when(cmd.getDescription()).thenReturn(null); when(cmd.getExternalId()).thenReturn(null); when(cmd.getUserDrivenBackups()).thenReturn(null); + when(cmd.getZoneId()).thenReturn(null); // Simulate resolver having provided the source offering domains (the real cmd#getDomainIds() would do this) when(cmd.getDomainIds()).thenReturn(sourceDomainIds);