From 7f5eb6463e57e3807504a1e49961991db441063f Mon Sep 17 00:00:00 2001
From: davidjumani <dj.davidjumani1994@gmail.com>
Date: Wed, 2 Dec 2020 13:59:03 +0530
Subject: [PATCH] Disallowing udp for lb rules for haproxy (#4501)

* Disallowing udp for lb rules

* Revert "Disallowing udp for lb rules"

This reverts commit a5f43014c9dded01d199d55a84fd6cdc4d10c90b.

* Adding check for udp rules for haproxy

* Adding defensive check
---
 .../java/com/cloud/network/router/NetworkHelperImpl.java   | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/server/src/main/java/com/cloud/network/router/NetworkHelperImpl.java b/server/src/main/java/com/cloud/network/router/NetworkHelperImpl.java
index 39b3f0da0e7..9751ddb7667 100644
--- a/server/src/main/java/com/cloud/network/router/NetworkHelperImpl.java
+++ b/server/src/main/java/com/cloud/network/router/NetworkHelperImpl.java
@@ -798,6 +798,13 @@ public class NetworkHelperImpl implements NetworkHelper {
             }
             return false;
         }
+        String lbProtocol = rule.getLbProtocol();
+        if (lbProtocol != null && lbProtocol.toLowerCase().equals(NetUtils.UDP_PROTO)) {
+            if (s_logger.isDebugEnabled()) {
+                s_logger.debug("Can't create LB rule as haproxy does not support udp");
+            }
+            return false;
+        }
 
         for (final LoadBalancingRule.LbStickinessPolicy stickinessPolicy : rule.getStickinessPolicies()) {
             final List<Pair<String, String>> paramsList = stickinessPolicy.getParams();