diff --git a/engine/schema/src/main/java/com/cloud/vm/dao/VMInstanceDaoImpl.java b/engine/schema/src/main/java/com/cloud/vm/dao/VMInstanceDaoImpl.java index 02d509be919..49d5d3f00f1 100755 --- a/engine/schema/src/main/java/com/cloud/vm/dao/VMInstanceDaoImpl.java +++ b/engine/schema/src/main/java/com/cloud/vm/dao/VMInstanceDaoImpl.java @@ -939,7 +939,8 @@ public class VMInstanceDaoImpl extends GenericDaoBase implem return customSearch(sc, null); } - protected Integer getPowerUpdateCount(final VMInstanceVO instance, final long powerHostId, final VirtualMachine.PowerState powerState, Date wisdomEra) { + protected Integer getPowerUpdateCount(final VMInstanceVO instance, final long powerHostId, + final VirtualMachine.PowerState powerState, Date wisdomEra) { if (instance.getPowerStateUpdateTime() == null || instance.getPowerStateUpdateTime().before(wisdomEra)) { Long savedPowerHostId = instance.getPowerHostId(); boolean isStateMismatch = instance.getPowerState() != powerState @@ -956,7 +957,8 @@ public class VMInstanceDaoImpl extends GenericDaoBase implem } @Override - public boolean updatePowerState(final long instanceId, final long powerHostId, final VirtualMachine.PowerState powerState, Date wisdomEra) { + public boolean updatePowerState(final long instanceId, final long powerHostId, + final VirtualMachine.PowerState powerState, Date wisdomEra) { return Transaction.execute((TransactionCallback) status -> { VMInstanceVO instance = findById(instanceId); if (instance == null) { @@ -989,7 +991,8 @@ public class VMInstanceDaoImpl extends GenericDaoBase implem } @Override - public Map updatePowerState(Map instancePowerStates, long powerHostId, Date wisdomEra) { + public Map updatePowerState( + final Map instancePowerStates, long powerHostId, Date wisdomEra) { Map notUpdated = new HashMap<>(); List instances = listSelectPowerStateByIds(new ArrayList<>(instancePowerStates.keySet())); Map updateCounts = new HashMap<>(); diff --git a/server/src/main/java/com/cloud/api/query/dao/UserVmJoinDao.java b/server/src/main/java/com/cloud/api/query/dao/UserVmJoinDao.java index eb166dcdf66..9cf487657fd 100644 --- a/server/src/main/java/com/cloud/api/query/dao/UserVmJoinDao.java +++ b/server/src/main/java/com/cloud/api/query/dao/UserVmJoinDao.java @@ -42,7 +42,6 @@ public interface UserVmJoinDao extends GenericDao { List listActiveByIsoId(Long isoId); - // TODO - We only need id, cpu and ram_size here. This could be done using JOIN on fly List listByAccountServiceOfferingTemplateAndNotInState(long accountId, List states, List offeringIds, List templateIds); } diff --git a/server/src/main/java/com/cloud/api/query/dao/UserVmJoinDaoImpl.java b/server/src/main/java/com/cloud/api/query/dao/UserVmJoinDaoImpl.java index e6f7392a7dc..db628f4788d 100644 --- a/server/src/main/java/com/cloud/api/query/dao/UserVmJoinDaoImpl.java +++ b/server/src/main/java/com/cloud/api/query/dao/UserVmJoinDaoImpl.java @@ -622,7 +622,7 @@ public class UserVmJoinDaoImpl extends GenericDaoBaseWithTagInformation listByAccountServiceOfferingTemplateAndNotInState(long accountId, List states, - List offeringIds, List templateIds) { + List offeringIds, List templateIds) { SearchBuilder userVmSearch = createSearchBuilder(); userVmSearch.selectFields(userVmSearch.entity().getId(), userVmSearch.entity().getCpu(), userVmSearch.entity().getRamSize());