From 5dba8cf430f125839b165c3cc682b4743c59147a Mon Sep 17 00:00:00 2001
From: Chiradeep Vittal <chiradeep@cloud.com>
Date: Mon, 29 Aug 2011 00:08:18 -0700
Subject: [PATCH] only update sequence number when asked to. full sync SHOULD
 NOT request sequence number updates since this will lead to the dog chasing
 its own tail

---
 .../cloud/network/security/SecurityGroupManagerImpl2.java  | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/server/src/com/cloud/network/security/SecurityGroupManagerImpl2.java b/server/src/com/cloud/network/security/SecurityGroupManagerImpl2.java
index f25bac5d8be..3df6371f69c 100644
--- a/server/src/com/cloud/network/security/SecurityGroupManagerImpl2.java
+++ b/server/src/com/cloud/network/security/SecurityGroupManagerImpl2.java
@@ -94,7 +94,10 @@ public class SecurityGroupManagerImpl2 extends SecurityGroupManagerImpl {
 
         Profiler p = new Profiler();
         p.start();
-        int updated = _rulesetLogDao.createOrUpdate(workItems);
+        int updated = 0;
+        if (updateSeqno) {
+            updated = _rulesetLogDao.createOrUpdate(workItems);
+        }
         int newJobs = _workQueue.submitWorkForVms(workItems);
         p.stop();
         if (s_logger.isTraceEnabled()){
@@ -183,7 +186,7 @@ public class SecurityGroupManagerImpl2 extends SecurityGroupManagerImpl {
 
     @Override
     public void cleanupFinishedWork() {
-        //no-op
+        //TODO: over time clean up op_vm_ruleset_log table for destroyed vms
     }
     
     /*