From 5e442df5a08ffd8f9d737fe54845984cf0139e33 Mon Sep 17 00:00:00 2001 From: Wei Zhou Date: Thu, 11 May 2023 09:27:51 +0200 Subject: [PATCH] ssvm: continue with other secondary storages if fails to program a secondary storage (#7264) This PR fixes #7244 --- .../secondarystorage/SecondaryStorageManagerImpl.java | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/services/secondary-storage/controller/src/main/java/org/apache/cloudstack/secondarystorage/SecondaryStorageManagerImpl.java b/services/secondary-storage/controller/src/main/java/org/apache/cloudstack/secondarystorage/SecondaryStorageManagerImpl.java index ac3567b21fd..d63e261d501 100644 --- a/services/secondary-storage/controller/src/main/java/org/apache/cloudstack/secondarystorage/SecondaryStorageManagerImpl.java +++ b/services/secondary-storage/controller/src/main/java/org/apache/cloudstack/secondarystorage/SecondaryStorageManagerImpl.java @@ -299,6 +299,7 @@ public class SecondaryStorageManagerImpl extends ManagerBase implements Secondar public boolean generateSetupCommand(Long ssHostId) { HostVO cssHost = _hostDao.findById(ssHostId); Long zoneId = cssHost.getDataCenterId(); + boolean result = true; if (cssHost.getType() == Host.Type.SecondaryStorageVM) { String hostName = cssHost.getName(); @@ -340,12 +341,12 @@ public class SecondaryStorageManagerImpl extends ManagerBase implements Secondar s_logger.debug(String.format("Successfully programmed secondary storage [%s] in secondary storage VM [%s].", ssStore.getName(), secStorageVm.getInstanceName())); } else { s_logger.debug(String.format("Unable to program secondary storage [%s] in secondary storage VM [%s] due to [%s].", ssStore.getName(), secStorageVm.getInstanceName(), answer == null ? "null answer" : answer.getDetails())); - return false; + result = false; } } } - return true; + return result; } @Override