From 619e753577d010a2902d2766125e2d732d8b9c5e Mon Sep 17 00:00:00 2001 From: Harikrishna Patnala Date: Wed, 31 May 2023 17:14:31 +0530 Subject: [PATCH] Removed unused unittests --- .../storage/VolumeApiServiceImplTest.java | 51 ------------------- 1 file changed, 51 deletions(-) diff --git a/server/src/test/java/com/cloud/storage/VolumeApiServiceImplTest.java b/server/src/test/java/com/cloud/storage/VolumeApiServiceImplTest.java index 71a4b76650e..8e246340dcb 100644 --- a/server/src/test/java/com/cloud/storage/VolumeApiServiceImplTest.java +++ b/server/src/test/java/com/cloud/storage/VolumeApiServiceImplTest.java @@ -1567,55 +1567,4 @@ public class VolumeApiServiceImplTest { Assert.assertFalse(volumeApiServiceImpl.isSendCommandForVmVolumeAttachDetach(host, Mockito.mock(StoragePoolVO.class))); } - @Test - public void testVolumeOnDifferentScaleIOStorageInstance() { - StoragePoolDetailVO srcPoolSystemIdDetail = Mockito.mock(StoragePoolDetailVO.class); - String srcPoolSystemId = "610204d03e3ad60f"; - when(srcPoolSystemIdDetail.getValue()).thenReturn(srcPoolSystemId); - - StoragePoolDetailVO destPoolSystemIdDetail = Mockito.mock(StoragePoolDetailVO.class); - String destPoolSystemId = "7332760565f6340f"; - when(destPoolSystemIdDetail.getValue()).thenReturn(destPoolSystemId); - - when(storagePoolDetailsDao.findDetail(1L,"powerflex.storagepool.system.id")).thenReturn(srcPoolSystemIdDetail); - when(storagePoolDetailsDao.findDetail(2L,"powerflex.storagepool.system.id")).thenReturn(destPoolSystemIdDetail); - - boolean result = volumeApiServiceImpl.isScaleIOVolumeOnDifferentScaleIOStorageInstances(1L, 2L); - - Assert.assertTrue(result); - } - - @Test - public void testVolumeOnSameScaleIOStorageInstance() { - StoragePoolDetailVO srcPoolSystemIdDetail = Mockito.mock(StoragePoolDetailVO.class); - String srcPoolSystemId = "610204d03e3ad60f"; - when(srcPoolSystemIdDetail.getValue()).thenReturn(srcPoolSystemId); - - StoragePoolDetailVO destPoolSystemIdDetail = Mockito.mock(StoragePoolDetailVO.class); - String destPoolSystemId = "610204d03e3ad60f"; - when(destPoolSystemIdDetail.getValue()).thenReturn(destPoolSystemId); - - when(storagePoolDetailsDao.findDetail(1L,"powerflex.storagepool.system.id")).thenReturn(srcPoolSystemIdDetail); - when(storagePoolDetailsDao.findDetail(2L,"powerflex.storagepool.system.id")).thenReturn(destPoolSystemIdDetail); - - boolean result = volumeApiServiceImpl.isScaleIOVolumeOnDifferentScaleIOStorageInstances(1L, 2L); - - Assert.assertFalse(result); - } - - @Test (expected = CloudRuntimeException.class) - public void testCheckVolumeOnDifferentScaleIOStorageInstanceSystemIdShouldNotBeNull() { - StoragePoolDetailVO srcPoolSystemIdDetail = Mockito.mock(StoragePoolDetailVO.class); - String srcPoolSystemId = "610204d03e3ad60f"; - when(srcPoolSystemIdDetail.getValue()).thenReturn(srcPoolSystemId); - - StoragePoolDetailVO destPoolSystemIdDetail = Mockito.mock(StoragePoolDetailVO.class); - when(destPoolSystemIdDetail.getValue()).thenReturn(null); - - when(storagePoolDetailsDao.findDetail(1L,"powerflex.storagepool.system.id")).thenReturn(srcPoolSystemIdDetail); - when(storagePoolDetailsDao.findDetail(2L,"powerflex.storagepool.system.id")).thenReturn(destPoolSystemIdDetail); - - volumeApiServiceImpl.isScaleIOVolumeOnDifferentScaleIOStorageInstances(1L, 2L); - } - }